447048 - User language preference not working correctly

Status: RESOLVED FIXED

(Webtools Graveyard :: Verbatim, defect)

Description

[Dan Schafer [:dschafer]]

When logging in, a user has already "chosen" his locale, since he is logging in from a /$lang/ domain.  This means, however, that his preference for language will not be used.

Additionally, if a user changes her preferred language, the options page will appear in her new language, but only for that iteration; any other page she visits will be in the original language.

Comment 1

[Dan Schafer [:dschafer]]

Attachment: Fix for login localization

Sets the localization to the current session-setting as a first priority.  This has the less-that-stellar side effect of the following HTTP request sequence for a Danish user logging in from an /en/ login page: 

POST /en/login.html HTTP/1.1" 302 -
GET /da/login.html?username=demouser&returnurl=[baseurl]/en/? HTTP/1.1" 302 -
GET /en/? HTTP/1.1" 302 -
GET /da/? HTTP/1.1" 200 -

I'll try and work up a cleaner solution shortly.

Comment 2

[Dan Schafer [:dschafer]]

Attachment: Lang fix without extraneous material

The previous patch had some extraneous code in it; this removes that.

I also don't see a better system for the login problem.

Comment 3

[Dan Schafer [:dschafer]]

Comment on attachment 332221 [details] [diff] [review]
Lang fix without extraneous material

This doesn't work as expected, and I'll wait until Attachment 332245 [details] [diff] for Bug 442313 is reviewed / landed to fix this patch (since the two patches operate on the same section of code)

Comment 4

[Dan Schafer [:dschafer]]

I'm now wondering what the desired behavior for language setting should be.  If a user goes to /en/foo.html, but is logged in with a German profile, should it redirect to /de/foo.html?  I'm inclined to say no, and hence the only influence your "user language" should have is what language you are directed to on login; after that, if you URL modify the language, verbatim will happily oblige.

Comment 5

[Dan Schafer [:dschafer]]

Attachment: Patch

This patch alters the behavior of login so that the user will be redirected to their selected language upon login.

Comment 6

[Wil Clouser [:clouserw]]

Comment on attachment 332992 [details] [diff] [review]
Patch

Logging in to:

/en/projects

tries to redirect me to:

/es/enprojects

(when es is the locale in my options)

Comment 7

[Wil Clouser [:clouserw]]

fixed in r 8417