447560 - xhydra/apple gcc patches: need to support plugging into ipa passes

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Vlad Sukhoy]

Attachment: testsuite error about ipa pass

This was around for a while.. http://hg.mozilla.org/users/tglek_mozilla.com/index.cgi/gcc-moz-plugin-mq/rev/e66bc0d60f10 introduced support for plugging ipa passes and http://hg.mozilla.org/users/tglek_mozilla.com/index.cgi/dehydra-gcc/rev/5fd0831f3b88 added a unit test which fails on mac because this support is not available in the port of plugin patch for mac. The unit test produces the error message which is attached.

Since the current mac build instructions require pulling the patches directly from bugzilla, need to change them to pull the mac patches from somewhere else where they can be modified, this should help with bug 438062 as well.

Comment 1

[Vlad Sukhoy]

Attachment: mac plugin.diff with ipa plugging

Pretty much the same code that works to plug into ipa passes on linux does the job on mac too.

Comment 2

[Vlad Sukhoy]

Attachment: test mod

"einline_ipa" is called just "einline" in Apple's gcc42 Preview 1.

Comment 3

[(dormant account)]

Comment on attachment 331685 [details] [diff] [review]
mac plugin.diff with ipa plugging

I'll take your word for it.

Comment 4

[(dormant account)]

Comment on attachment 331686 [details] [diff] [review]
test mod

frustrating when names differ, but it'll let this slide to have testsuite pass. Thanks for the fix

Comment 5

[Vlad Sukhoy]

Pushed and updated the URLs in the docs for now.