447638 - 'details' links don't load on tinderbox waterfalls for talos results (series links broken)

Status: VERIFIED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[alice nodelman [:alice] [:anode]]

Take any details graphs from http://tinderbox.mozilla.org/showbuilds.cgi?tree=Firefox and select a 'Details' graph link for a set of talos results.  The graph server front page loads, but the graph never loads.

eg: http://graphs.mozilla.org/graph.html#type=series&show=1225375

Comment 1

[alice nodelman [:alice] [:anode]]

Could be related to bug 446056.

Comment 2

[Ryan Doherty (:rdoherty)]

Dupe of bug 438716.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified dup

Comment 4

[alice nodelman [:alice] [:anode]]

I don't believe that this is a dupe.  The other bug is about the series data page itself not loading, this is more about links to series graphs not working - which they still don't

Comment 5

[Ryan Doherty (:rdoherty)]

Attachment: Fix for broken links

This patch fixes the broken links issue. I think it could be written better, but after staring at it for a while, I can't see out how. 

Hoping Les can lend his expertise :)

Comment 7

[Ryan Doherty (:rdoherty)]

Attachment: Fix for broken links

New fix that also grabs buildid.

Comment 8

[Chris Cooper [:coop] (he/him)]

Comment on attachment 337895 [details] [diff] [review]
Fix for broken links

Looks good. Patch applied fine here and seems to work from casual testing.

> function transformLegacySeriesData(testList)
> {
>     //log(testList.toSource());
> 
>-    gTestList = [];
>-    if(!gAllTestsList) {
>-        gAllTestsList = [];
>-    }
>-        
>-    gSeriesTestList = {};
>-
>-    var quickList = {};
>-

Glad to see this useless stanza go too.

Comment 9

[Ryan Doherty (:rdoherty)]

committed, revision 114:421f1e0ce02b

For QA:

1) Load http://graphs-stage.mozilla.org/graph.html#type=series
2) Select the date picker for a test
3) Select 2 or more test that are not the first test listed
4) Copy the url linked to by 'link to the graph' in the bottom right box
5) Paste the url into a new tab or window
6) Verify all tests load

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; followed the instructions in comment 9, above, and the two graphs were identical (I even hovered over various point to ensure the given data was reflected across both).