447640 - DrawTraceTrees should not use a Stringp for filename

Status: RESOLVED FIXED

(Tamarin Graveyard :: Tracing Virtual Machine, defect)

Description

[Edwin Smith]

we start out with a platform friendly filename (eg char*), convert to Stringp, pass through a bunch of layers, then have to convert back to platform filename to call fopen().  so, just simplest to pass the char* down.

Comment 1

[Mason Chang]

Attachment: Uses char * instead of Stringp to pass file name to the trace tree drawer

Comment 2

[Edwin Smith]

Comment on attachment 330965 [details] [diff] [review]
Uses char * instead of Stringp to pass file name to the trace tree drawer

the wince code needs to be touched at least enough to make sure it compiles, otherwise, looks good.

Comment 3

[Mason Chang]

Attachment: Fixes so it compiles under CE

Comment 4

[Edwin Smith]

Comment on attachment 330970 [details] [diff] [review]
Fixes so it compiles under CE

push when ready

Comment 5

[Mason Chang]

Attachment: Fixed linux compile bug

Comment 6

[Edwin Smith]

Comment on attachment 331031 [details] [diff] [review]
Fixed linux compile bug

this looks like a copy of the original patch.  but anyway, if linux is happy go ahead and push, i trust it was simple fix.

Comment 7

[Mason Chang]

It was basically the same thing, just added a const in one location. I pushed it last night after linux was happy.