Closed Bug 447640 Opened 11 years ago Closed 11 years ago

DrawTraceTrees should not use a Stringp for filename

Categories

(Tamarin Graveyard :: Tracing Virtual Machine, defect)

x86
Windows XP
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: edwsmith, Unassigned)

Details

Attachments

(1 file, 2 obsolete files)

we start out with a platform friendly filename (eg char*), convert to Stringp, pass through a bunch of layers, then have to convert back to platform filename to call fopen().  so, just simplest to pass the char* down.
Comment on attachment 330965 [details] [diff] [review]
Uses char * instead of Stringp to pass file name to the trace tree drawer

the wince code needs to be touched at least enough to make sure it compiles, otherwise, looks good.
Attachment #330965 - Flags: review?(edwsmith) → review+
Attached patch Fixes so it compiles under CE (obsolete) — Splinter Review
Attachment #330965 - Attachment is obsolete: true
Comment on attachment 330970 [details] [diff] [review]
Fixes so it compiles under CE

push when ready
Attachment #330970 - Flags: review+
Attachment #330970 - Attachment is obsolete: true
Attachment #331031 - Attachment is patch: true
Attachment #331031 - Attachment mime type: application/octet-stream → text/plain
Comment on attachment 331031 [details] [diff] [review]
Fixed linux compile bug

this looks like a copy of the original patch.  but anyway, if linux is happy go ahead and push, i trust it was simple fix.
Attachment #331031 - Flags: review+
It was basically the same thing, just added a const in one location. I pushed it last night after linux was happy.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.