Closed Bug 447642 Opened 12 years ago Closed 11 years ago

get rid of --disable-mochitest, replace MOZ_MOCHITEST with ENABLE_TESTS

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla1.9.1b1

People

(Reporter: ted, Assigned: ted)

References

Details

Attachments

(1 file, 1 obsolete file)

I don't see any reason that mochitest needs a special configure flag at this point. We should get rid of that configure flag and its associated define, and just use the more general ENABLE_TESTS instead.
Attached patch get rid of MOZ_MOCHITEST (obsolete) — Splinter Review
This should do it. Most of the patch is s/MOZ_MOCHITEST/ENABLE_TESTS/, but there are a few cases where I was able to collapse things a bit better, and a few cases where we were already in a tests/ directory that is only built ENABLE_TESTS, so I was able to remove the ifdef completely.
Assignee: nobody → ted.mielczarek
Status: NEW → ASSIGNED
Attachment #337455 - Flags: review?(benjamin)
Forgot a backslash in one Makefile, and forgot to remove my workaround in testing/mochitest/Makefile.in.
Attachment #337455 - Attachment is obsolete: true
Attachment #337485 - Flags: review?(benjamin)
Attachment #337455 - Flags: review?(benjamin)
Attachment #337485 - Flags: review?(benjamin) → review+
Pushed:
http://hg.mozilla.org/mozilla-central/rev/1023e41aa9b4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
Blocks: 458988
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.