447652 - "Bookmarks -> Organize -> Import -> Restore" doesn't list JSON backup files with localized filenames

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Alexander L. Slovesnik]

STR:
1. Install localized version Firefox with localized value of bookmarksArchiveFilename (http://mxr.mozilla.org/firefox/source/toolkit/locales/en-US/chrome/places/places.properties#21)
2. Use it for while
3. Open "Bookmarks -> Organize -> Import -> Restore"

Actual Results: No backup JSON files are shown.
Expected Results: Backup JSON files are shown.

Also see Bug 445704, that asks to unlocalize bookmarksArchiveFilename

Comment 1

[Axel Hecht [:Pike]]

http://mxr.mozilla.org/mozilla/source/toolkit/components/places/src/utils.js#1608 hardcodes the English string for bookmarksArchiveFilename, and should just use the localized value.

Or we should in general untranslate that like bug 445704 says, which would work for folks changing back and forth between languages, too. That's just an edge case to an edge case, though.

Comment 2

[Søren Munk Skrøder (extended hiatus)]

In my opinion, we should unlocalize this - or not have any filtering active at all in the .js module...

This is an area of low visibillity, UI wise, and therefore it does not hurt to have the backups appear as "bookmarks-YYYY-MM-DD.json"...

I find it more severe that the js filtering apparently hides any bookmark backup that does not conform to the locale of the current Firefox instance... 

As Axel said, it's an edge case - but in my view, we either drop the localizing of the filename - or we drop the filtering... 

IMHO, the first option is more "open", and thus better ;-D

Comment 3

[Jeferson Hultmann]

looks like bug 445704 will fix this.

Comment 4

[Marco Bonardo [:mak]]

after bug 445704 we don't use anymore localized filenames plus the dialog should not show also old localized backups.

So fixed by bug 445704

Comment 5

[Tracy Walker [:tracy]]

verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; es-ES; rv:1.9.1b2) Gecko/20081201 Firefox/3.1b2