Closed
Bug 447702
Opened 16 years ago
Closed 16 years ago
bug 441686 causes problems for API violators
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
INVALID
People
(Reporter: crowderbt, Assigned: crowderbt)
References
Details
Attachments
(1 file)
2.01 KB,
patch
|
Details | Diff | Splinter Review |
C code, such as liveconnect, which erroneously consumes private headers from spidermonkey, gets confused by the use of the "inline" keyword. Here's a patch.
Assignee | ||
Comment 1•16 years ago
|
||
The last time I tinkered with JS_INLINE, I seriously considered created a JS_FORCE_INLINE to do what this does, and a JS_INLINE to use the "inline" keyword where it's available. Perhaps as we move more towards C++, that becomes increasingly the right thing to do, but I am unsure.
Assignee | ||
Comment 2•16 years ago
|
||
Attachment #331016 -
Flags: review?(igor)
Comment 3•16 years ago
|
||
(In reply to comment #0) > C code, such as liveconnect, which erroneously consumes private headers from > spidermonkey, gets confused by the use of the "inline" keyword. Here's a > patch. What is exactly the confusion? static inline in C99 has the same semantics as in C++.
Assignee | ||
Comment 4•16 years ago
|
||
Here's a log from the try server: http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1216769174.1216771603.5866.gz
Assignee | ||
Comment 5•16 years ago
|
||
Comment on attachment 331016 [details] [diff] [review] inline => JS_INLINE This patch unfortunately causes lots of warnings about the unused functions, in my build. I'll investigate the TryServer build problems more.
Attachment #331016 -
Flags: review?(igor)
Comment 6•16 years ago
|
||
(In reply to comment #4) > Here's a log from the try server: > http://tinderbox.mozilla.org/showlog.cgi?log=MozillaTry/1216769174.1216771603.5866.gz This have a simple explanation: MSVC does not support C99 including the inline keyword :( . I guess the simplest solution is to use macros.
Assignee | ||
Comment 7•16 years ago
|
||
This was fixed elsewhere.
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•