447703 - Include commit log in hg revision title

Status: RESOLVED INCOMPLETE

(Developer Services :: Mercurial: hg.mozilla.org, defect, P3)

Description

[Ed Lee :Mardak]

I was trying to find a revision that I recently looked at..

url: http://hg.mozilla.org/mozilla-central/index.cgi/rev/860fd53ec15c
title: mozilla-central: changeset 16003:860fd53ec15c 
desc: Bug 431842: refactor autocomplete binding to support Fennec autocomplete, r=gavin

I typed "hg.moz fennec" but didn't find anything only to realize the title of the revision page didn't have anything useful.

Putting the commit message into the title probably just needs changing to filerevision.tmpl to have {desc|escape} of some sort.

Comment 1

[Benjamin Smedberg]

http://hg.mozilla.org/index.cgi/hg_templates/ patches welcome

Comment 2

[Ed Lee :Mardak]

Attachment: v1

Tested locally with |hg serve| and ended up with something like..

mozilla-central: Added tag FIREFOX_3_1a1_RELEASE for changeset 9d9941eacb14 (changeset 16138:277a21a074e7)

However, I disabled my interhg pattern to prevent bug links from getting linkified for other commit messages.

Comment 3

[Benjamin Smedberg]

Comment on attachment 331014 [details] [diff] [review]
v1

You need to add the firstline filter

Comment 4

[Ed Lee :Mardak]

Is that desired? Multi-line commit logs merge into a single line in the title. Basically..

<title>first line
second line</title>

And shows up as "first line second line".

Comment 5

[Ed Lee :Mardak]

Attachment: v1.1

(In reply to comment #3)
> You need to add the firstline filter
Added firstline before escaping.

Only showing the first line is consistent with the bolded single line that shows commit log and relevant tags.

Most commits probably have the bulk of the interesting information in the first line, but adding other lines gives the smart location bar something else to search.

Comment 6

[Ed Lee :Mardak]

Do I just push this to hg_templates? Making it live on hg.mozilla.org is a separate thing?

Comment 7

[Benjamin Smedberg]

Publish your hg_templates repository somewhere... then get aravind to pull your repo into the official hg_templates and update the server... you can probably use this bug and just reassign it to him.

Comment 8

[Ed Lee :Mardak]

Comment on attachment 331464 [details] [diff] [review]
v1.1

This attachment is |hg export|ed, so someone should be able to |hg import| and commit it.

Comment 9

[Dirkjan Ochtman (:djc)]

So this should probably get deployed, then? You should reassign to Server Ops (and CC Aravind) or Aravind to get this going.

Comment 10

[(not currently active) Ted Mielczarek]

Needs to be committed first. This isn't a big enough change that I'd bother asking for a new rollout anyway. It can wait to ride along when we get something bigger, or accumulate enough small changes.

Comment 11

[(not currently active) Ted Mielczarek]

(In reply to comment #7)
> Publish your hg_templates repository somewhere... then get aravind to pull your
> repo into the official hg_templates and update the server... you can probably
> use this bug and just reassign it to him.

I dunno, we have just been pushing stuff to hg_templates without problems. It's not like there are a ton of people hacking on it. I'd say just push it there.

Comment 12

[(not currently active) Ted Mielczarek]

Did you ever commit this?

Comment 13

[Gregory Szorc [:gps]]

5 year old bug with no activity. Reopen if you would still like this.