Closed
Bug 447844
Opened 17 years ago
Closed 17 years ago
Fix build with JS_HAS_SCRIPT_OBJECT
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: graydon, Unassigned)
Details
Attachments
(1 file)
|
849 bytes,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Current build fails when JS_HAS_SCRIPT_OBJECT is defined. Minor drift, nothing serious.
Attachment #331169 -
Flags: review?(mrbkap)
|
||
Comment 1•17 years ago
|
||
Comment on attachment 331169 [details] [diff] [review]
patch fixing build
>- obj = js_NewObject(cx, &js_ScriptClass, NULL, NULL);
>+ obj = JS_NewObject(cx, &js_ScriptClass, NULL, NULL);
Prefer js_NewObject(..., 0) over going through the API entry point. r=mrbkap with that.
Attachment #331169 -
Flags: review?(mrbkap) → review+
|
Reporter | |
Comment 2•17 years ago
|
||
Pushed with change you suggest, in revision b51037907ac2.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
||
Updated•17 years ago
|
Flags: in-testsuite-
Flags: in-litmus-
You need to log in
before you can comment on or make changes to this bug.
Description
•