447848 - warnings introduced by bug 384244 should be fixed

Status: RESOLVED WONTFIX

(Core :: JavaScript Engine, defect)

Description

[Brian Crowder]

Summary says it all.  Patch coming.

Comment 1

[Brian Crowder]

Attachment: needs to be taken for a spin

Igor:  Can you try this patch to see if it silences the warnings?

Comment 2

[Igor Bukanov]

(In reply to comment #1)
> Created an attachment (id=331189) [details]
> needs to be taken for a spin
> 
> Igor:  Can you try this patch to see if it silences the warnings?

With the patch I got a single warning:

dtoa.c:3210: warning: suggest parentheses around && within ||

Comment 3

[Igor Bukanov]

Comment on attachment 331189 [details] [diff] [review]
needs to be taken for a spin


> 		len = (sizeof(Bigint) + (x-1)*sizeof(ULong) + sizeof(double) - 1)
> 			/sizeof(double);
>-		if (pmem_next - private_mem + len <= PRIVATE_mem) {
>+		if (pmem_next - private_mem + len <= (unsigned int) PRIVATE_mem) {

Here the type of len and the type of the cast should be size_t, not unsigned int, for 64-bit cleanness.

Comment 4

[Brian Crowder]

I have backed out the dtoa patch, so I'll reland with these fixes when it relands, and ask you to test your build again.

Comment 5

[Igor Bukanov]

(In reply to comment #4)
> I have backed out the dtoa patch, so I'll reland with these fixes when it
> relands, and ask you to test your build again.

Sure.