Closed Bug 447928 Opened 12 years ago Closed 12 years ago

HKCU protocol / file handlers won't be updated after update or during an in place upgrade

Categories

(Firefox :: Installer, defect)

3.0 Branch
x86
Windows Vista
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)

Details

(Keywords: fixed1.9.0.2)

Attachments

(1 file)

IsHandlerForInstallDir should use SHCTX to determine if the Registry key should be updated. It is also possible that HKLM will get updated when HKCU is set.
Attached patch patch rev1Splinter Review
This updates the handlers for both HKCU and HKLM during install and after update.

-  ReadRegStr $6 HKCR ".hht" ""
+  ReadRegStr $6 HKCR ".xht" ""
This was a typo

-!ifdef ___WINVER__NSH___
Makes it so we require NSIS 2.22

The remainder is to make it consistent when checking string equality.
Attachment #331269 - Flags: review?(jmathies)
Drivers, this probably doesn't need to block 1.9.0.2 but I would very much like to land it for 1.9.0.2. This is how we update protocol / file handlers when software update runs or the installer is run on top of an existing install.
Flags: wanted1.9.0.x?
Version: 2.0 Branch → 3.0 Branch
Flags: blocking1.9.0.2?
Flags: blocking-firefox3.1?
Attachment #331269 - Flags: review?(jmathies) → review+
Checked in to mozilla-central

changeset:   16263:59ed47fea07d
tag:         tip
user:        Robert Strong <robert.bugzilla@gmail.com>
date:        Sun Jul 27 18:58:27 2008 -0700
summary:     Bug 447928 - HKCU protocol / file handlers won't be updated after update or during an in place upgrade. r=jmathies
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 331269 [details] [diff] [review]
patch rev1

Drivers, this patch fixes a bug where we won't update the protocol handlers properly during install or software update.
Attachment #331269 - Flags: approval1.9.0.2?
Wanted, but not blocking.
Flags: wanted1.9.0.x?
Flags: wanted1.9.0.x+
Flags: blocking1.9.0.2?
Flags: blocking1.9.0.2-
Comment on attachment 331269 [details] [diff] [review]
patch rev1

Approved for 1.9.0.2. Please land in CVS. a=ss
Attachment #331269 - Flags: approval1.9.0.2? → approval1.9.0.2+
Checked in for 1.9.0.2 / Firefox 3.0.2

Checking in mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh,v  <--  commo
n.nsh
new revision: 1.43; previous revision: 1.42
done
Checking in mozilla/browser/installer/windows/nsis/installer.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/installer.nsi,v  <--  installer.
nsi
new revision: 1.44; previous revision: 1.43
done
Checking in mozilla/browser/installer/windows/nsis/shared.nsh;
/cvsroot/mozilla/browser/installer/windows/nsis/shared.nsh,v  <--  shared.nsh
new revision: 1.20; previous revision: 1.19
done
Keywords: fixed1.9.0.2
Flags: blocking-firefox3.1?
You need to log in before you can comment on or make changes to this bug.