447928 - HKCU protocol / file handlers won't be updated after update or during an in place upgrade

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

IsHandlerForInstallDir should use SHCTX to determine if the Registry key should be updated. It is also possible that HKLM will get updated when HKCU is set.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch rev1

This updates the handlers for both HKCU and HKLM during install and after update.

-  ReadRegStr $6 HKCR ".hht" ""
+  ReadRegStr $6 HKCR ".xht" ""
This was a typo

-!ifdef ___WINVER__NSH___
Makes it so we require NSIS 2.22

The remainder is to make it consistent when checking string equality.

Comment 2

[Robert Strong (they/them - no direct email)]

Drivers, this probably doesn't need to block 1.9.0.2 but I would very much like to land it for 1.9.0.2. This is how we update protocol / file handlers when software update runs or the installer is run on top of an existing install.

Comment 3

[Robert Strong (they/them - no direct email)]

Checked in to mozilla-central

changeset:   16263:59ed47fea07d
tag:         tip
user:        Robert Strong <[e-mail]>
date:        Sun Jul 27 18:58:27 2008 -0700
summary:     Bug 447928 - HKCU protocol / file handlers won't be updated after update or during an in place upgrade. r=jmathies

Comment 4

[Robert Strong (they/them - no direct email)]

Comment on attachment 331269 [details] [diff] [review]
patch rev1

Drivers, this patch fixes a bug where we won't update the protocol handlers properly during install or software update.

Comment 5

[Samuel Sidler (old account; do not CC)]

Wanted, but not blocking.

Comment 6

[Samuel Sidler (old account; do not CC)]

Comment on attachment 331269 [details] [diff] [review]
patch rev1

Approved for 1.9.0.2. Please land in CVS. a=ss

Comment 7

[Robert Strong (they/them - no direct email)]

Checked in for 1.9.0.2 / Firefox 3.0.2

Checking in mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh;
/cvsroot/mozilla/toolkit/mozapps/installer/windows/nsis/common.nsh,v  <--  commo
n.nsh
new revision: 1.43; previous revision: 1.42
done
Checking in mozilla/browser/installer/windows/nsis/installer.nsi;
/cvsroot/mozilla/browser/installer/windows/nsis/installer.nsi,v  <--  installer.
nsi
new revision: 1.44; previous revision: 1.43
done
Checking in mozilla/browser/installer/windows/nsis/shared.nsh;
/cvsroot/mozilla/browser/installer/windows/nsis/shared.nsh,v  <--  shared.nsh
new revision: 1.20; previous revision: 1.19
done