448001 - Developer stats graph doesn't show up at all

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Basil Hashem [:baz]]

I'm putting this in Developer Pages instead of stats since it's likely a CSS/JS/mini-fication issue rather than stats per se.

Comment 1

[Les Orchard [:lorchard]]

I'm not entirely sure how stats works, but FWIW it looks like this page has a JS error in the inline JS produced by the overall site layout related to advanced search:

$ svn blame site/app/views/layouts/mozilla.thtml  | grep "getElementById('advanced-search-toggle-link')"

 17213 [e-mail]         document.getElementById('advanced-search-toggle-link').href="#";   // for ff2, ie6-7

This breaks when there's no search element on the page, which could be causing all JS on the page to bail out after that point.

Comment 2

[Justin Scott [:fligtar]]

Yep, Les is right. We need to fix ASAP and push again - more pages than just stats don't have a search box.

Comment 3

[Chris Pollett]

Attachment: patch to fix advance search toggle js error

As Les pointed out the error was caused because JS was dying when the  given id was not found (related to the search element). The raison d'etre of this code was to allow toggling of the advance search form under ie 6-7. The patch implements Les' suggested fix from irc. This got rid of the JS error on the statistics page which does not have the search element. I then went and checked that toggling of the advance search form still works in ie 6 and 7. It did.

Comment 4

[Les Orchard [:lorchard]]

Comment on attachment 331328 [details] [diff] [review]
patch to fix advance search toggle js error

Looks okay to me, in that the JS error went away and the page seems to work.

Comment 5

[Chris Pollett]

Okay, checked into r17398

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

https://addons.mozilla.org/en-US/statistics/addon/5579 and other public-stats add-ons work just fine, so verified FIXED; no longer seeing the JavaScript error: "Error: document.getElementById("advanced-search-toggle-link") is null
Source File: https://preview.addons.mozilla.org/en-US/statistics/addon/5579
Line: 61"

Tested IE 6 and 7 in addition to Firefox 2/3.