448007 - [FIX] Make nsEventDispatcher.cpp useable from non-main thread

Status: RESOLVED WORKSFORME

(Core :: DOM: Events, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

The idea is to use the event target chain pool (which is an optimization) only 
from main-thread.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: like this

This makes nsEventTargetChainItem::Create to use |new|
and nsEventTargetChainItem::Destroy to use |delete| when
non-main-thread is used.

Bent, does this fulfill your requirements?

(For some reason hg diff -w doesn't work, with that the patch would have be smaller.)

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 331344 [details] [diff] [review]
like this

This'll work great!

However we might want to hold off landing this until we make sure that the rest of the stuff-off-main-thread strategy is working.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Updated to tip

I think we should land this now.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

So workers have non-CC-able event implementations? What about
event listener managers?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Or what kind of setup do we have?

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

This has been fixed elsewhere. All the DOM event dispatching goes through EventDispatcher.