Closed Bug 448020 Opened 12 years ago Closed 12 years ago

configure crashes when /bin/sh == /bin/dash and config.cache is present

Categories

(Firefox Build System :: General, defect)

x86
Linux
defect
Not set

Tracking

(Not tracked)

VERIFIED FIXED
mozilla1.9.1a2

People

(Reporter: dbaron, Assigned: dbaron)

References

Details

(Keywords: fixed1.9.0.2)

Attachments

(1 file)

As a result of the changes to configure.in in bug 442279, configure crashes on Ubuntu systems where /bin/sh is dash rather than bash, and when a config.cache is present from a previous run of configure.  In other words, this crash is a result of the change:
http://hg.mozilla.org/mozilla-central/index.cgi/diff/9871082391f5/configure.in
Attached patch patchSplinter Review
Assignee: nobody → dbaron
Status: NEW → ASSIGNED
Attachment #331343 - Flags: superreview?(ted.mielczarek)
Attachment #331343 - Flags: review?(l10n)
Comment on attachment 331343 [details] [diff] [review]
patch

I don't get why it crashes, but ok!
Attachment #331343 - Flags: superreview?(ted.mielczarek) → superreview+
Attachment #331343 - Flags: review?(l10n) → review+
Ah, I didn't file because the obvious simplified testcase didn't exhibit the problem, and I wasn't in the mood to simplify configure down to a testcase (though it may be worth doing).

In any case, fixed:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/589f091246af
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1a2
Comment on attachment 331343 [details] [diff] [review]
patch

Approved for 1.9.0.2. Please land in CVS. a=ss

(Taking per bug 442279 comment 9.)
Attachment #331343 - Flags: approval1.9.0.2+
Landed in CVS.
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.0.2
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.