448020 - configure crashes when /bin/sh == /bin/dash and config.cache is present

Status: VERIFIED FIXED

(Firefox Build System :: General, defect)

Description

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8]

As a result of the changes to configure.in in bug 442279, configure crashes on Ubuntu systems where /bin/sh is dash rather than bash, and when a config.cache is present from a previous run of configure.  In other words, this crash is a result of the change:
http://hg.mozilla.org/mozilla-central/index.cgi/diff/9871082391f5/configure.in

Comment 1

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8]

Attachment: patch

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 331343 [details] [diff] [review]
patch

I don't get why it crashes, but ok!

Comment 3

[Mats Palmgren (:mats)]

FWIW, I filed this to Ubuntu yesterday:
https://bugs.launchpad.net/ubuntu/+source/dash/+bug/251889

Comment 4

[David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-8]

Ah, I didn't file because the obvious simplified testcase didn't exhibit the problem, and I wasn't in the mood to simplify configure down to a testcase (though it may be worth doing).

In any case, fixed:
http://hg.mozilla.org/mozilla-central/index.cgi/rev/589f091246af

Comment 5

[Samuel Sidler (old account; do not CC)]

Comment on attachment 331343 [details] [diff] [review]
patch

Approved for 1.9.0.2. Please land in CVS. a=ss

(Taking per bug 442279 comment 9.)

Comment 6

[Axel Hecht [:Pike]]

Landed in CVS.