448099 - Automate litmus test Testcase ID #5066 - Active download - Go to Download Page

Status: NEW

(Toolkit :: Downloads API, defect)

Description

[Anoop Saldanha (Poona)]

Proposed type of test: chrome

Proposed location of test: toolkit/mozapps/downloads/tests/chrome

Comment 1

[Anoop Saldanha (Poona)]

Attachment: v1.0

Test runs.  The comments that apply to bug 448097 applies to this as well.

Comment 2

[Anoop Saldanha (Poona)]

Attachment: v2.0

Patch updated.  Corrected a small indentation mistake.

Comment 3

[Shawn Wilsher :sdwilsh]

Comment on attachment 331518 [details] [diff] [review]
v2.0

This needs to be in browser/ because it depends on the browser

>+/**
>+ * We define a custom populateDM() and not use the populateDM() defined in
>+ * utils.js, since we require the dummy download to also have the referrer url.
>+ */
Then let's fix utils.js to bind null if the property doesn't exist on the
object being passed in.  Code duplication FTL.

>+function runTest()
>+{
>+  const dmui = Cc["@mozilla.org/download-manager-ui;1"].
>+             getService(Ci.nsIDownloadManagerUI);
>+  const dm = Cc["@mozilla.org/download-manager;1"].
>+             getService(Ci.nsIDownloadManager);
s/const/let/

>+  const prefServ = Cc["@mozilla.org/preferences-service;1"].
>+                   getService(Ci.nsIPrefBranch);
ditto

>+  let initialPrefValue = prefServ.getIntPref("browser.link.open_newwindow");
>+  prefServ.setIntPref("browser.link.open_newwindow", 3);
what's that do exactly?  comments would be nice

>+      let chromeWin = wm.getMostRecentWindow("navigator:browser");
s/chromeWin/browser/

>+        // Cleanup
>+        prefServ.setIntPref("browser.link.open_newwindow", initialPrefValue);
>+        setCleanState();
do this at the end of the test?

>+      function popupListener() {
>+        let menuitem = popup.childNodes;
>+        for(let i = 0; i < menuitem.length; i++) {
>+          if(menuitem[i].label == "Go to Download Page")
>+            menuitem[i].doCommand();
check the command, not string name please

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.