44810 - Mac hangs with a plugin in the Plugins folder

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Peter Van der Beken]

From Bugzilla Helper:
User-Agent: Mozilla/4.07 (Macintosh; I; PPC, Nav)
BuildID:    2000061408

The latest check-in (version 1.130) by [e-mail] into mozilla/modules/
plugin/nglsrc/nsPluginHostImpl.cpp breaks plug-ins on Mac. Line 2478 does not 
work for Mac:

nsresult rvIsLayoutPath = compManager->SpecForRegistryLocation("rel:gkhtml.dll", 
getter_AddRefs(path));

gkhtml.dll is not a library on Mac.

Reproducible: Always
Steps to Reproduce:
Make sure a plugin (for example MRJPlugin) is in the Plugins folder. Launch with 
Profile Manager, then try to create a new profile.

Actual Results:  I see the following in the console:

nsNativeComponentLoader: 
GetFactory(HD:Mozilla:mozilla:dist:viewer_debug:Components:gkhtml.dll) Load 
Failed with error: error 0.

Comment 1

[av (gone)]

Cut and paste thing, sorry, I'll remove it. But it should not break any existing 
functionality, it should just fail and go like it was before. What do you mean 
by 'Plug-ins broken on Mac'?

Comment 2

[Peter Van der Beken]

I'll change it. When i have a plugin in the Plugins folder, mozilla hangs.

First i get:

nsNativeComponentLoader: 
GetFactory(HD:Mozilla:mozilla:dist:viewer_debug:Components:gkhtml.dll) Load 
Failed with error: error 0.

Then later these two:

###!!! ASSERTION: NS_ENSURE_TRUE(docShellElement) failed: 'docShellElement', 
file nsXULWindow.cpp, line 733

and

###!!! ASSERTION: NS_ENSURE_TRUE(window) failed: 'window', file 
nsContentTreeOwner.cpp, line 567

and after a couple of these it hangs. Removing the plugin resolves the problem.

Comment 3

[Kathleen :Brade]

This is a bad bug (I'm being asserted to death); can we get a fix soon?

Comment 4

[av (gone)]

I checked in the fix for LAYOUT_DLL yesterday. Do you still see this?

Comment 5

[av (gone)]

OK, as brade suggested I changed rel:LAYOUT_DLL to LAYOUT_DLL for Mac which 
seems to fix the problem. Peter would you please confirm?

Comment 6

[Peter Van der Beken]

Fixed. Thanks.

Comment 7

[shrirang khanzode]

marking verified (2000071708)