448173 - SM: Fail to build shell on win32

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Bob Clary [:bc] (inactive)]

Igor, I think this is yours.

link.exe kernel32.lib user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib oldnames.lib winmm.lib -nologo -subsystem:windows -dll -debug -pdb:./WINNT5.1_OPT.OBJ/js32.pdb -machine:I386 -opt:ref -opt:noicf /base:0x61000000  \
	    /out:"WINNT5.1_OPT.OBJ/js32.dll" /pdb:none\
	    /implib:"./WINNT5.1_OPT.OBJ/js32.lib" WINNT5.1_OPT.OBJ/jsapi.obj WINNT5.1_OPT.OBJ/jsarena.obj WINNT5.1_OPT.OBJ/jsarray.obj WINNT5.1_OPT.OBJ/jsatom.obj WINNT5.1_OPT.OBJ/jsbool.obj WINNT5.1_OPT.OBJ/jscntxt.obj WINNT5.1_OPT.OBJ/jsdate.obj WINNT5.1_OPT.OBJ/jsdbgapi.obj WINNT5.1_OPT.OBJ/jsdhash.obj WINNT5.1_OPT.OBJ/jsdtoa.obj WINNT5.1_OPT.OBJ/jsemit.obj WINNT5.1_OPT.OBJ/jsexn.obj WINNT5.1_OPT.OBJ/jsfun.obj WINNT5.1_OPT.OBJ/jsgc.obj WINNT5.1_OPT.OBJ/jshash.obj WINNT5.1_OPT.OBJ/jsinterp.obj WINNT5.1_OPT.OBJ/jsinvoke.obj WINNT5.1_OPT.OBJ/jsiter.obj WINNT5.1_OPT.OBJ/jslock.obj WINNT5.1_OPT.OBJ/jslog2.obj WINNT5.1_OPT.OBJ/jslong.obj WINNT5.1_OPT.OBJ/jsmath.obj WINNT5.1_OPT.OBJ/jsnum.obj WINNT5.1_OPT.OBJ/jsobj.obj WINNT5.1_OPT.OBJ/jsopcode.obj WINNT5.1_OPT.OBJ/jsparse.obj WINNT5.1_OPT.OBJ/jsprf.obj WINNT5.1_OPT.OBJ/jsregexp.obj WINNT5.1_OPT.OBJ/jsscan.obj WINNT5.1_OPT.OBJ/jsscope.obj WINNT5.1_OPT.OBJ/jsscript.obj WINNT5.1_OPT.OBJ/jsstr.obj WINNT5.1_OPT.OBJ/jsutil.obj WINNT5.1_OPT.OBJ/jsxdrapi.obj WINNT5.1_OPT.OBJ/jsxml.obj WINNT5.1_OPT.OBJ/prmjtime.obj
LINK : fatal error LNK1181: cannot open input file 'c:\mozilla-build\msys\implib;.\WINNT5.1_OPT.OBJ\js32.lib'

Comment 1

[Igor Bukanov]

Attachment: fix v1

AFAICS MSVC does not like ./ as a start of a library path. So the patch makes sure that ./ is stripped from the patch. Does it work on Windows?

Comment 2

[Bob Clary [:bc] (inactive)]

Comment on attachment 331477 [details] [diff] [review]
fix v1

r+: I can build opt/debug shell on windows with this. Thanks.

Comment 3

[Igor Bukanov]

landed - http://hg.mozilla.org/index.cgi/mozilla-central/rev/2b63d4eb1fe7

(In reply to comment #2)
> r+: I can build opt/debug shell on windows with this. Thanks.

Thanks for testing the patch!