448250 - OS/2 broken since cairo upgrade

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Peter Weilbacher]

Since cairo was upgraded to 1.6.4-348-g96c9e2a in bug 446323, OS/2 is broken. Not only is there a build break (see bug 446323 comment 5) but our FontConfig "clone" is missing FcPatternGetFTFace(). When adding that as a dummy that returns FcResultTypeMismatch we are still crashing (at the strdup() call in _cairo_ft_unscaled_font_init() in cairo-ft-font.c, because the filename never gets set).

The build break because of _cairo_font_face_reset_static_data is fixed in cairo upstream but I need to figure out if there is a cairo problem on OS/2 and how to properly implement FcPatternGetFTFace(). Then we can maybe update cairo again to fix OS/2.

Comment 1

[Peter Weilbacher]

We also need to implement FcFreeTypeCharIndex in our FontConfig soon, see <http://gitweb.freedesktop.org/?p=cairo;a=commit;h=ba95b9dee8e6daddbeb0660d920c7b46801edc80>.

Comment 2

[Peter Weilbacher]

OK, so the only fix needed is indeed the rename to  _cairo_font_face_reset_static_data as in git commit d560a3d96563d681f5c0d8ebea0d255ac35bbc99 (http://gitweb.freedesktop.org/?p=cairo;a=commit;h=d560a3d96563d681f5c0d8ebea0d255ac35bbc99). I'm going to push this now to mozilla-central.

Everything else needs to be fixed in mzfntcfgft. I have done that and will release a new package soon.

Comment 3

[Peter Weilbacher]

OK, fix of cairo-os2-surface.c pushed (changeset f60fb1f1f3e7).

Comment 4

[Peter Weilbacher]

I put the new support package onto hobbes in the meantime, although it's still in incoming:
   http://hobbes.nmsu.edu/pub/incoming/mzfntcfgft_20080806.zip