448494 - Remove nsprpub/configure from mozilla-central

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Peter Weilbacher]

Attachment: Do it

The version of nsprpub/configure in mozilla-central causes problems on OS/2 where we need to regenerate it, apparently with some stuff specific for our system. For nightlies, my script does that automatically, but for manual builds and releases I always forget that...

Like the main configure file nsprpub/configure will be recreated from source by the build system if it is not there, so I propose to remove it from Hg. If it is added to .hgignore, too, it won't be added back with later NSPR updates.

Comment 1

[Peter Weilbacher]

Comment on attachment 331703 [details] [diff] [review]
Do it

Maybe Ted is faster reviewing this...

Comment 2

[Benjamin Smedberg]

I don't think we want to do this. I'd really like to get back to checking in the main configure script as well, but I don't want to remove this file which is part of the standard NSPR sources.

Comment 3

[Peter Weilbacher]

Then what do you suggest we should do on OS/2? It will break the build every time after a pull/update. As a configure run takes a few minutes this is really annoying. Is there a fancy Hg trick to not update this file?

At least I believe I found a way to not accidentally check in my changed version. For that I added ignore.mozilla = ~/.hgignore.mozilla to ~/.hgrc and in that file list nsprpub/configure.

Comment 4

[Benjamin Smedberg]

hg revert nsprpub/configure ?

Comment 5

[Peter Weilbacher]

I don't really see how hg revert is supposed to help. With that I always get the "bad" one that is pulled from tip.

I guess I'll file a new bug to support RUN_AUTOCONF_LOCALLY with client.py.