448506 - xlink:show="new" does not work in SVG

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Armin Müller]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; de; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1

we have the following code segment in a SVG which is included into a html with <embed>
<text x="0" y="46" class="normal2">expltext <a xlink:href="http://www.nowhere.de" xlink:show="new" focusHighlight="none">text</a></text>
but xlink:show="new" is ignored by FF 

Reproducible: Always

Steps to Reproduce:
start URL
click on uismedia

Actual Results:  
the URL will be shown inside the embed

Expected Results:  
the URL should be shown as a new window. This works fine with Opera, Safari and IE

Comment 1

[Robert Longson [:longsonr]]

Attachment: patch

You should really be using target rather than xlink:show. xlink:show is or will be deprecated (http://www.w3.org/TR/SVGMobile12/linking.html#xlinkRefAttrs) and is only relevant when there is no target attribute.

Comment 2

[Robert Longson [:longsonr]]

Attachment: updated patch

On second thoughts it makes sense that xlink:show="replace" skip GetBaseTarget.

Comment 3

[Armin Müller]

(In reply to comment #1)
> You should really be using target rather than xlink:show. xlink:show is or will
> be deprecated (http://www.w3.org/TR/SVGMobile12/linking.html#xlinkRefAttrs) and
> is only relevant when there is no target attribute.
> 
Unfortunately Adobe SVGViewer 3.x which is based on SVG 1.1 does not understand target="_blank"

Comment 4

[Robert Longson [:longsonr]]

You could try using both attributes I suppose.

Comment 5

[Armin Müller]

(In reply to comment #4)
> You could try using both attributes I suppose.
> 
I tried this but it doesnt work. It seems the target attribute has a higher priority in ASV too. Unfortunately only target="_top" works with ASV and this attribute replace the window in FF but do not open a new one. 

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 331728 [details] [diff] [review]
updated patch

+      aTarget.AssignLiteral("_blank");
+    case 1:

Add a comment to make it clear you fall through to the return. Actually, better to just add a 'return'.

Comment 7

[Robert Longson [:longsonr]]

Attachment: for check-in

Comment 8

[Robert Longson [:longsonr]]

checked in 3ec0cb079898