Add CamiTools to the "problematic add-ons" list

RESOLVED FIXED

Status

Camino Graveyard
General
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Smokey Ardisson (offline for a while; not following bugs - do not email), Assigned: Chris Lawson (gone))

Tracking

({fixed1.8.1.19})

Details

Attachments

(1 attachment, 1 obsolete attachment)

2.55 KB, patch
Stuart Morgan
: review+
Mike Pinkerton (not reading bugmail)
: superreview+
Details | Diff | Splinter Review
CamiTools has been incompatible with all versions of Camino since 1.0.x; unfortunately, many people still have it installed, and it is starting to cause crashes with 1.6.1 (on startup or when opening prefs).

We could completely prevent it from loading, but our consensus is that it's better to let it load so that when people encounter other sorts of problems (of the kinds it is famous for causing), people realize that they do have CamiTools installed.

However, given that it *is* incompatible, we should warn about it.  Since it's not an InputManager, it probably doesn't load in time for the existing mechanism.  However, Stuart thinks we should be able to look for it by the path.
Flags: camino1.6.3?
Not making 1.6.4.
Flags: camino2.0?
Flags: camino1.6.5?
Flags: camino1.6.4?
Flags: camino1.6.4-
(Assignee)

Updated

9 years ago
Assignee: nobody → cl-bugs-new
Hardware: Macintosh → All
(Assignee)

Comment 2

9 years ago
Created attachment 344324 [details] [diff] [review]
fix v1.0

Checks both user and global paths for anything with "camitools" in the name and throws the warning if it finds something.
Attachment #344324 - Flags: review?(stuart.morgan+bugzilla)

Updated

9 years ago
Attachment #344324 - Flags: review?(stuart.morgan+bugzilla) → review-

Comment 3

9 years ago
Comment on attachment 344324 [details] [diff] [review]
fix v1.0

>+      NSEnumerator* prefPaneEnumerator = [installedUserPreferencePanes objectEnumerator];
>+      NSString* paneName;
>+      while ((paneName = [prefPaneEnumerator nextObject])) {
>+        if ([paneName rangeOfString:@"CamiTools" options:NSCaseInsensitiveSearch].location != NSNotFound)
>+          [addOnsPresent addObject:@"CamiTools"];
>+      }
>+      prefPaneEnumerator = [installedGlobalPreferencePanes objectEnumerator];
>+      while ((paneName = [prefPaneEnumerator nextObject])) {
>+        if ([paneName rangeOfString:@"CamiTools" options:NSCaseInsensitiveSearch].location != NSNotFound)
>+          [addOnsPresent addObject:@"CamiTools"];
>+      }

Don't repeat the loop, just make a combined array and walk that.
(Assignee)

Comment 4

9 years ago
Created attachment 345040 [details] [diff] [review]
fix v1.1

Fixed.
Attachment #344324 - Attachment is obsolete: true
Attachment #345040 - Flags: review?(stuart.morgan+bugzilla)

Updated

9 years ago
Attachment #345040 - Flags: superreview?(mikepinkerton)
Attachment #345040 - Flags: review?(stuart.morgan+bugzilla)
Attachment #345040 - Flags: review+

Comment 5

9 years ago
Comment on attachment 345040 [details] [diff] [review]
fix v1.1

r=me
Comment on attachment 345040 [details] [diff] [review]
fix v1.1

sr=pink
Attachment #345040 - Flags: superreview?(mikepinkerton) → superreview+
Landed on cvs trunk and MOZILLA_1_8_BRANCH for 1.6.5.

For future reference, the way to test these changes is to set config/version.txt to a full version number (and make sure you have a Universal one of these annoying-to-install hacks installed).
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: camino2.0?
Flags: camino1.6.5?
Flags: camino1.6.5+
Keywords: fixed1.8.1.19
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.