448592 - Add CamiTools to the "problematic add-ons" list

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

CamiTools has been incompatible with all versions of Camino since 1.0.x; unfortunately, many people still have it installed, and it is starting to cause crashes with 1.6.1 (on startup or when opening prefs).

We could completely prevent it from loading, but our consensus is that it's better to let it load so that when people encounter other sorts of problems (of the kinds it is famous for causing), people realize that they do have CamiTools installed.

However, given that it *is* incompatible, we should warn about it.  Since it's not an InputManager, it probably doesn't load in time for the existing mechanism.  However, Stuart thinks we should be able to look for it by the path.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Not making 1.6.4.

Comment 2

[Chris Lawson (gone)]

Attachment: fix v1.0

Checks both user and global paths for anything with "camitools" in the name and throws the warning if it finds something.

Comment 3

[Stuart Morgan]

Comment on attachment 344324 [details] [diff] [review]
fix v1.0

>+      NSEnumerator* prefPaneEnumerator = [installedUserPreferencePanes objectEnumerator];
>+      NSString* paneName;
>+      while ((paneName = [prefPaneEnumerator nextObject])) {
>+        if ([paneName rangeOfString:@"CamiTools" options:NSCaseInsensitiveSearch].location != NSNotFound)
>+          [addOnsPresent addObject:@"CamiTools"];
>+      }
>+      prefPaneEnumerator = [installedGlobalPreferencePanes objectEnumerator];
>+      while ((paneName = [prefPaneEnumerator nextObject])) {
>+        if ([paneName rangeOfString:@"CamiTools" options:NSCaseInsensitiveSearch].location != NSNotFound)
>+          [addOnsPresent addObject:@"CamiTools"];
>+      }

Don't repeat the loop, just make a combined array and walk that.

Comment 4

[Chris Lawson (gone)]

Attachment: fix v1.1

Fixed.

Comment 5

[Stuart Morgan]

Comment on attachment 345040 [details] [diff] [review]
fix v1.1

r=me

Comment 6

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 345040 [details] [diff] [review]
fix v1.1

sr=pink

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Landed on cvs trunk and MOZILLA_1_8_BRANCH for 1.6.5.

For future reference, the way to test these changes is to set config/version.txt to a full version number (and make sure you have a Universal one of these annoying-to-install hacks installed).