display files in pushlog

RESOLVED INCOMPLETE

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED INCOMPLETE
9 years ago
3 years ago

People

(Reporter: Robert Kaiser, Assigned: Sid Kalra)

Tracking

Details

Attachments

(2 attachments, 4 obsolete attachments)

(Reporter)

Description

9 years ago
It would be a good idea if we could display the changed files in pushlog, so we know if something like "move the deprecated section to the end of this file" is something the viewer of this comment should care about (e.g. is it something my Mozilla-derived product, my localization, my theme, my extension needs to react to?).

Updated

9 years ago
Duplicate of this bug: 455219
Without the list of changed files showing in the pushlog (like bonsai view did), it has become quite a task to find out which bug has caused a regression range.
For example, if there was a regression in selection, then normally I would look for changes nsSelection.cpp in the regression range. That's not possible now, I have to look at the checkin comment (which can be really obscure) to have an idea what the checkin was about.
Well, you can use http://hg.mozilla.org/mozilla-central/log/789b491cc8d4/layout/generic/nsSelection.cpp.
Yes, well, I would not be sure there were actual changes in nsSelection.cpp, it could be in other, related files.

Basically, I want similar as this:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=day&mindate=&maxdate=&cvsroot=%2Fcvsroot
But now I have this:
http://hg.mozilla.org/mozilla-central/pushloghtml
I have to open the changeset link to find out what files were changed during the checkin, which is a lot more work.

Comment 5

9 years ago
Sid asked me to assign this bug to him via irc.
Assignee: nobody → sid
(Assignee)

Comment 6

9 years ago
Created attachment 348451 [details] [diff] [review]
Patch for the pushlog to show files touched
Attachment #348451 - Flags: review?(jorendorff)
(Assignee)

Comment 7

9 years ago
Created attachment 348452 [details] [diff] [review]
Patch for templates to show files touched
Attachment #348452 - Flags: review?(jorendorff)
Comment on attachment 348451 [details] [diff] [review]
Patch for the pushlog to show files touched

I would prefer to see a <ul> for the filesTouched.  You can suppress the bullets with CSS.

But this is not a big deal and I'm all for getting something pushed quickly.
Attachment #348451 - Flags: review?(jorendorff) → review+
Attachment #348452 - Flags: review?(jorendorff) → review+
Comment on attachment 348452 [details] [diff] [review]
Patch for templates to show files touched

Is there a way to put that CSS in a separate stylesheet instead of the template?
Status: NEW → ASSIGNED
(Assignee)

Comment 10

8 years ago
Created attachment 372298 [details] [diff] [review]
Patch for hgpoller to show files touched

The pushlog has gone through some changes since this patch was approved last year. I've updated it to work with the current version of the pushlog. Please see the following link for more details:

http://blog.sidkalra.com/2009/04/v09-release-updating-the-files-touched-patch/
Attachment #348451 - Attachment is obsolete: true
Attachment #372298 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 11

8 years ago
Created attachment 372299 [details] [diff] [review]
Patch for hg_templates to show files touched

Moved the CSS to a style sheet. Please see the following link for more details:

http://blog.sidkalra.com/2009/04/v09-release-updating-the-files-touched-patch/
Attachment #348452 - Attachment is obsolete: true
Attachment #372299 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 12

8 years ago
Created attachment 374462 [details] [diff] [review]
Patch for hgpoller to show files touched

Added expand/collapse functionality

Please see the following link for more details: 

http://blog.sidkalra.com/2009/04/v10-release-completev10-release-complete/
Attachment #372298 - Attachment is obsolete: true
Attachment #374462 - Flags: review?(ted.mielczarek)
Attachment #372298 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 13

8 years ago
Created attachment 374463 [details] [diff] [review]
Patch for hg_templates to show files touched

Added expand/collapse functionality

Please see the following link for more details: 

http://blog.sidkalra.com/2009/04/v10-release-completev10-release-complete/
Attachment #372299 - Attachment is obsolete: true
Attachment #374463 - Flags: review?(ted.mielczarek)
Attachment #372299 - Flags: review?(ted.mielczarek)
Ted, looking at your review queue, these patches go back a while.  Do you have review comments that haven't been addressed in order for you to r+?  If not, are you planning to review?  And, if you don't think we should take these, can you r-?  

If there are comments that have yet to be addressed, does it make sense to clear these requests and ask for another request after the comments have been addressed?
Comment on attachment 374462 [details] [diff] [review]
Patch for hgpoller to show files touched

Clearing old review requests. We can revisit these at a later date.
Attachment #374462 - Flags: review?(ted.mielczarek)
Comment on attachment 374463 [details] [diff] [review]
Patch for hg_templates to show files touched

Clearing old review requests. We can revisit these at a later date.
Attachment #374463 - Flags: review?(ted.mielczarek)
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services

Updated

3 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/232]
It's a good idea, but it's a 4 year old bug with no activity.
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → INCOMPLETE
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/232]
You need to log in before you can comment on or make changes to this bug.