Closed Bug 448714 Opened 16 years ago Closed 16 years ago

Opening and Closing pages with Theora <video> elements causes out of memory

Categories

(Core :: DOM: Core & HTML, defect)

x86
All
defect
Not set
major

Tracking

()

VERIFIED FIXED
mozilla1.9.1a2

People

(Reporter: cajbir, Assigned: cajbir)

Details

(Keywords: memory-leak)

Attachments

(1 file)

Repeatedly opening and closing videos loaded via the <video> element eventually results in running out of memory, or large memory usage by Firefox.

Originally reported as part of bug 448534, but confirmed by me to occur and is a separate issue to the bug.
This is caused by a strong reference to the ogg decoder being help by the observer service. As a result the decoder is never destroyed and lots of memory is held. Patch forthcoming.
This fixes two issues. The first is the observer service was keeping a strong reference to the decoder, preventing it from being deleted. This resulted in a leak.

The second is if the video was playing when the media element was destroyed, the ogg decoder was not stopped, resulting in a thread remaining active and preventing the decoder from being destroyed. This also resulted in a leak.
Attachment #331906 - Flags: superreview?(roc)
Attachment #331906 - Flags: review?(roc)
Attachment #331906 - Flags: superreview?(roc)
Attachment #331906 - Flags: superreview+
Attachment #331906 - Flags: review?(roc)
Attachment #331906 - Flags: review+
Keywords: mlk
Keywords: checkin-needed
Pushed 39f9e7845d34
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Keywords: checkin-needed
Target Milestone: --- → mozilla1.9.1a2
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: