44873 - 3pane Search menu (items/mnemonics) should match spec

Status: VERIFIED INVALID

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[Ninoschka Baca]

Overview: In the 3pane the mnemonics for the Search menu should match the spec.

Comment 1

[timeless]

agreed

Comment 2

[timeless]

Spec needs some fixes.
Search All Mail is now Search &Mail/News Messages.
Someone needs to give me info about the rest of these strange creatures
I think the spec as posted is for ns6
People Finder 
Business and Companies > 
Product Search 
Maps and Directions 
Reference Desk > 
-
I'm tempted to not do that portion of the spec because i don't think anyone 
should have the hassle of selecting a noncommercial service provider for each 
of these.

mpt i'd like to hear your comments. And could you fill out the depends list for 
this bug? (I think i'll be working from these generic bugs because there's one 
for everything)

Comment 3

[timeless]

*** Bug 44881 has been marked as a duplicate of this bug. ***

Comment 4

[Matthew T (active 1999-2002)]

You want my comments? Ok, here they are: The `Search' menu should not exist at 
all. (E-mail me, or post in n.p.m.ui, if you want the list of reasons in all its 
gory detail.)

... But I expect that wasn't quite what you were looking for. :-)

The summary says `3pane Mnemonics: Search menu should match spec'. Therefore, 
updating URL to a spec which actually has mnemonics in it. The commercial items 
mentioned in the previous URL obviously should not be in Mozilla.

What does `Smart Search' do? (Danger, danger! I don't understand it, others won't 
either!) If it's a Netscape search function, a la SmartBrowse, you can get rid of 
that from the non-commercial builds too.

The spec is missing a mnemonic for `Find Again'; G seems the obvious choice here, 
to match the shortcut.

The spec also says `"Find in Message..." and "Find Again" only sensitive when the 
message body has focus'. This is wrong. It should be `"Find in Message..." and 
"Find Again" only enabled when a message body is visible.' Two reasons:
* the message pane doesn't -- or shouldn't -- have to have focus for the menu
  item to work, otherwise users will get very confused indeed;
* the message pane might have focus but not be showing a message (e.g. if
  multiple messages are selected), in which case the menu item should not be
  enabled.

There don't seem to be any dependencies. Bug 37306, bug 38344, bug 38958, and bug 
39151 cover Messenger's Search menu in various situations, and bug 40818 is a 
tracker for menu cleanup. But all of these seem to be directed at the items 
themselves, not their mnemonics.

Comment 5

[lchiang]

cc: jennifer to read previous comments.

Comment 6

[jglick]

Several Points:

1. The Search menu for the Netscape commerical and mozilla builds are gonna need 
to be different.
2. The URL to the Mail link in this bug is Netscape centric.
3. Need a decision on how the Search menu for NS commerical and Mozilla should 
differ.
4. John Gable owns the Search menu for the NS build. The contents of this menu 
are still open and need to be finalized.
5. We should probably have separate bugs for NS commerical Search menu and the 
Mozilla Search menu?

Reassigning this bug to John Gable for [e-mail]

Comment 7

[johng]

There have been no changes to the Search menu basic plan from beta1.  The Search
menu in Mail, Address Book, Composer and Navigator should match each other
except for any component specific items - per German's spec all along (cc'ing
German).  That gives the user a consistent search experience in each component -
that is the objective.

Navigator is implemented correctly: it includes the "My Sidebar Search Panel >"
link as well as an overlay for the Netscape build with links to several web
search services.

I have noticed some other inconsistencies between Mail and Navigator search
menus - mail includes a grayed out "Search on this Computer" option and the
other searches are also grayed out.  We should clean up these inconsistencies as
well.

Reassigning to German since he owns the cross-component search UI spec.

Comment 8

[jglick]

John or German, is there an up to date spec anywhere that specifies what the 
Search menu should contain for each component? The only docs I know of, John's 
doc and German's doc, seem out of date and not completely consistent with each 
other.

Also, both these docs reference specific Netcenter items. I'm assuming the 
Mozilla builds should just remove those items?

http://client/seamonkey/navigator/search-concepts.htm#menu
http://gooey/client/5.0/specs/search/

Comment 9

[johng]

*** Bug 44761 has been marked as a duplicate of this bug. ***

Comment 10

[johng]

Ignore my doc (I've updated it to say "do not use as spec) and refer to German's
spec at gooey.  However, that spec is also out of date - German needs to either
update that or put mroe details into this bug.

Also, these links to search services at Netcenter do not need to be part of the
mozilla build.  For Navigator, we used overlays to manage the difference.

Comment 11

[Matthew T (active 1999-2002)]

No John, we can't `refer to German's spec at gooey'. Error FW-1, unknown WWW 
server.

Please update the spec on mozilla.org. Any work to fix the menu is likely to be 
done by [e-mail], who (as far as I know) isn't skilled at cracking 
into corporate firewalls. :-)

Comment 12

[Matthew T (active 1999-2002)]

Resummarizing, since bug 44761 (Search menu items) was marked as a dup of this 
bug (Search menu mnemonics).

Comment 13

[jglick]

This is what is currently in the product (with Address Book removed). Is this 
correct? What changes are needed?  & = mnemonic

&Find in this <Page/Message>...  Ctrl+F 
Find &Again  Ctrl+G
----------------
Search the &Web
Search &Bookmarks/History  
Search Mail/News &Messages                                              
--------------------
My &Sidebar Search Panel ---> &Basic
                             &Advanced
----------------------
(NS6)Business
(NS6)Maps and Directions
(NS6)People Finder
(NS6)Reference Desk
(NS6)Shopping Search
---------------------
&Internet Keywords  


NOTE: Search AB has been removed since this will not be available.

Comment 14

[Matthew T (active 1999-2002)]

* Just to contradict my earlier comment: `Find _Again' should be `Find _Next'.
  This is both more obvious, and more commonly used in programs which have
  separate find and find-next functions (e.g. Notepad, Wordpad).
* `My Sidebar Search Panel' is an ugly name. What does it do? I can't tell. My
  best guess would be that it searches the contents of your currently open
  sidebar panels.
* `My Sidebar Search Panel' should be a single menu item. I can't tell, from
  within the menu, whether I'll want the Basic or Advanced version; so changing
  the mode should be done with a control in the dialog/whatever itself, not in
  the `Search' menu.
* For forwards compatibility, I suggest using K (instead of I) as the mnemonic
  for `Internet Keywords'.

Comment 15

[german]

Jennifer's stab looks proper to me. See bug 44724 for the Sidebar Search Tab 
item. Matt's suggestion for K as menmonic for Keywords sounds better also. Will 
try to post updated spec for menus asap to mozilla.org

Comment 16

[hangas]

Marking nsbeta3- while assigned to german

Comment 17

[James Green]

If someone would like to come along and finalise the specs here, I'll go in and
do it. Note: the Search menu is all but abolished in Browser land, is this the
case in MailNews land too (should we be bothering here)? Taking bug.

Jennifer and German: can you and mpt get together and agree on this please, then
we'll all be happy.

Comment 18

[jglick]

Honestly, I am not sure what is supposed to be in the Search menu anymore. Kevin 
or John or Sol, could you take a look at this bug? What is recommended for the 
Search menu for mozilla? And what should be in the search menu for commerical 
(4617).

Comment 19

[kmurray1115]

Mail seems to be fine as is, although I'm not opposed to mpt's changes either.
I'll defer to tpringle for browser.

Comment 20

[jglick]

So Mail is:

_F_ind in This Message Ctrl+F
Find A_g_ain   Ctrl+G
--------------------
Search Mail/News _M_essages
--------------------
Search the _W_eb

"Find _N_ext" instead of "Find Again" as suggested by mpt is also fine if 
preferred.

Comment 21

[timeless]

*** Bug 44918 has been marked as a duplicate of this bug. ***

Comment 22

[timeless]

dupe has attachment 38365 [details] [diff] [review] which is based on mpt's suggestions.

please test/review/debate

Comment 23

[Olga]

I change resolution to Invalid for originally logged bugs for 3pane Main Menus.
Some design changes happened since that time and now expectation is different.
Current status of Main Menus is addressed in the summary bug 75622, which tracks
a few leftovers for Main Menu mnemonic issues in 3-pane window according to
updated Spec. So original ones can be closed.

Comment 24

[Olga]

Verified.