449019 - No tooltip by mouse over event in unifinder

Status: VERIFIED FIXED

(Calendar :: Lightning Only, defect)

Description

[Andreas Treumann]

STEPS TO REPRODUCE:
===================

- Make unifinder visible
- move mouse over an event in the unifinder

RESULT:
=======

- nothing

EXPECTED RESULT:
================

- tooltip should be visible

REPRODUCIBLE:
=============

- always

Comment 1

[Stefan Sitter [:ssitter]]

Works for me using Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8.1.17pre) Gecko/2008081619 Calendar/0.9pre.

Did this used to work in Lightning before?

Comment 2

[Pete Riley]

In Lightning's Unifinder, I see a tooltip for the Title if it doesn't fit in the column.  However, there isn't a tooltip that shows Title/Date/Location/Description/etc (like in the main view).  Which is wanted?  Maybe this is a feature request instead of a regression.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This is a regression.

I moved the tooltips into our common sets to fix this bug. I could have consolidated that code a bit but I decided not to since we are shortly before a release and I don't want to risk more regressions. I have some bitrotted code in bug 366680 that consolidates the code, but that bug is a pain to fix on branch due to XUL peculiarities.

I also added some simple caching to the item tooltip code since I noticed some CPU load while hovering over items in the views.

Comment 4

[Berend Cornelius]

Comment on attachment 334237 [details] [diff] [review]
Fix - v1

I regret I have to deny the patch because the tooltip is still not displayed on the tasktree in taskmode. After discussion with Pilipp I am taking over.

Comment 5

[Berend Cornelius]

Attachment: patch v. #2

I resolved the remaining issue and did some consolidation.

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 334477 [details] [diff] [review]
patch v. #2

r=philipp

Comment 7

[Berend Cornelius]

patch checked in on trunk and MOZILLA_1_8_BRANCH
->FIXED

Comment 8

[Andreas Treumann]

Checked in lightning 2008081919 and sunbird 20080819 -> VERIFIED

Comment 9

[Simon Paquet [:sipaq]]

This caused Bug 451327