If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

dehydra: Expose C++ accessibility (public|private|protected)

RESOLVED FIXED

Status

()

Core
Rewriting and Analysis
RESOLVED FIXED
9 years ago
6 years ago

People

(Reporter: Benjamin Smedberg, Assigned: (dormant account))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

9 years ago
I need accessibility information from dehydra. I have a patch which I'll attach which works for methods/fields, but I can't seem to find the right magic for base accessibility. Taras, can you take a look at the base visibility stuff?
(Reporter)

Comment 1

9 years ago
Created attachment 332239 [details] [diff] [review]
Expose access on C++ decls (and bases, in theory), rev. 1
(Reporter)

Comment 2

9 years ago
Testcase .cpp/.js are at http://hg.mozilla.org/users/bsmedberg_mozilla.com/testcases/index.cgi/file/8b5b2a6bc80c/dehydra/access.cpp and http://hg.mozilla.org/users/bsmedberg_mozilla.com/testcases/index.cgi/file/8b5b2a6bc80c/treehydra/dehydra-dump-types.js
(Assignee)

Comment 3

9 years ago
Created attachment 332770 [details] [diff] [review]
Fixed lazy_types and added corresponding stuff to dehydra
Attachment #332239 - Attachment is obsolete: true
Attachment #332770 - Flags: review?(benjamin)
(Reporter)

Comment 4

9 years ago
Comment on attachment 332770 [details] [diff] [review]
Fixed lazy_types and added corresponding stuff to dehydra

Couple of notes:

in lazy_types.js there's a stale comment about BINFO_BASE_ACCESSES

in test_treehydra_dehydra_types there's a commented-out print() that should just be removed
Attachment #332770 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

9 years ago
pushed
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Depends on: 449639
(Reporter)

Comment 6

9 years ago
I committed a fixup for the mozilla-central tests that use .bases to update to the new schema.
(Assignee)

Updated

9 years ago
Blocks: 437502

Updated

6 years ago
Assignee: nobody → tglek
You need to log in before you can comment on or make changes to this bug.