Closed
Bug 449150
Opened 16 years ago
Closed 16 years ago
In <find-leakers.pl>, fix code nits and add output sorting
Categories
(Testing :: General, defect)
Testing
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9
People
(Reporter: sgautherie, Assigned: sgautherie)
Details
(Keywords: polish)
Attachments
(1 file)
|
1.86 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
Sorting helps finding out the interesting (serial number) range(s).
|
Assignee | |
Comment 1•16 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/2008080121 Minefield/3.1a2pre] (home, debug default) (W2Ksp4) *Enable Perl |strict| mode. *Add/Remove |my ...| as needed. *(Re)Move a couple blank lines. *Add examples of input/output lines. *Add a |delete()| call, not required but better to stay in sync'. *Add output sorting. *Double-check how it is written, as I copied/adapted some code I found...
How did you test this?
|
|
Assignee | |
Comment 3•16 years ago
|
||
(In reply to comment #2) On bug 448980.
Comment on attachment 332293 [details] [diff] [review] (Av1) <find-leakers.pl> [Checkin: Comment 5] r=dbaron
Attachment #332293 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 5•16 years ago
|
||
Pushed to mozilla-central: http://hg.mozilla.org/mozilla-central/index.cgi/rev/f6fb4a4be499
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
|
|
||
Updated•16 years ago
|
Keywords: checkin-needed,
polish
|
|
Assignee | |
Updated•16 years ago
|
Attachment #332293 -
Attachment description: (Av1) <find-leakers.pl> → (Av1) <find-leakers.pl>
[Checkin: Comment 5]
|
||
Updated•16 years ago
|
Component: Testing → General
Product: Core → Testing
QA Contact: testing → general
Target Milestone: mozilla1.9.1a2 → mozilla1.9
You need to log in
before you can comment on or make changes to this bug.
Description
•