449220 - opening the eml-attachment in a forwarded email does not work

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Mugros]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: Version 2.0.0.16 (20080708)

If i forward an email the edit message windows comes up with the forwarded email as an eml-attachment. If i click on the attached eml a blank window opens and i get this error in the error console:

Fehler: uncaught exception: [Exception... "Component returned failure code: 0x80550006 [nsIMsgFolder.getMsgDatabase]"  nsresult: "0x80550006 (<unknown>)"  location: "JS frame :: chrome://messenger/content/messageWindow.js :: CreateView :: line 346"  data: no]

Reproducible: Always

Steps to Reproduce:
1. forward an email
2. double-click the eml-attachment in the email to be forwarded

Actual Results:  
blank message window

Expected Results:  
The original email should be displayed

Tested it without add-ons and with a clean profile. Same result.

Comment 1

[Noèl Köthe]

I can reproduce this with TB 2.0.0.16 with one (but maybe more, didn't test them all) messages but not with all.

I'm trying to find out why this email produce this problem. Its a 8bit MIME email with two eml's attached.

Comment 2

[Theodor Storm]

I am experiencing this exact problem using a clean installation of Thunderbird 2.0.0.19, no extensions. My steps to reproduce:

1. Send a simple message (title "test", body text "test") to myself
2. Fetch it using POP3
3. Forward it
4. Double-click the eml-attachment in the email to be forwarded.

OR

1. Create a simple message (title "test", body text "test", no recipient) and save it as a draft
2. Forward it
3. Double-click the eml-attachment in the email to be forwarded.

Actual results:
Blank message window, javascript error console shows "Fel: uncaught exception: [Exception... "Component returned failure code: 0x80550006 [nsIMsgFolder.getMsgDatabase]"  nsresult: "0x80550006 (<unknown>)"  location: "JS frame :: chrome://messenger/content/messageWindow.js :: CreateView :: line 346"  data: no]"

Expected results:
Forwarded e-mail should be displayed in messge window

Note that I have tried reproducing this problem by forwarding IMAP and news messages, and the error has NOT occured. I have only been able to reproduce the problem using POP3 messages and drafts.


Example message which I have used to reproduce this problem:
--------------------------------------------------------------------------------
From - Tue Jan 27 20:21:49 2009
X-Account-Key: account2
X-UIDL: 1233084130809.2865220528.19370.zeke
X-Mozilla-Status: 0001
X-Mozilla-Status2: 00000000
X-Mozilla-Keys:                                                                                 
Return-Path: <[e-mail]>
Delivered-To: [e-mail]
X-Spam-Checker-Version: SpamAssassin 3.1.7-deb (2006-10-05) on zeke.tstorm.se
X-Spam-Level: *
X-Spam-Status: No, score=1.4 required=8.0 tests=AWL,BAYES_50,RCVD_IN_PBL,
	SPF_SOFTFAIL autolearn=no version=3.1.7-deb
X-AuthUser: [e-mail]
Received: from [192.168.1.117] ([91.149.40.37]:51285)
	by mail.tstorm.se with [XMail 1.22 ESMTP Server]
	id <S12E9DD> for <[e-mail]> from <[e-mail]>;
	Tue, 27 Jan 2009 20:22:10 +0100
Message-ID: <[e-mail]>
Date: Tue, 27 Jan 2009 20:21:38 +0100
From: Theodor Storm <[e-mail]>
User-Agent: Thunderbird 2.0.0.19 (Windows/20081209)
MIME-Version: 1.0
To: [e-mail]
Subject: test
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

test

--------------------------------------------------------------------------------

Comment 3

[Joel Goguen]

This has been reported against Thunderbird 2.0.0.18 at https://launchpad.net/bugs/234030.

Comment 4

[Tobias Koenig]

Attachment: Fixes opening of attached .eml files

messageWindow.js expects a msgHdr now as argument to show the attachment, so pass in the header instead of two url/uris.

Comment 5

[Rain [:rain1] (inactive)]

Forgot to mention this on IRC, but you can use the MailUtils module's displayMessage to open the message. This has the added benefit of obeying the user's preference on where to open messages. <http://mxr.mozilla.org/comm-central/source/mail/base/modules/MailUtils.js#131>

Comment 6

[David :Bienvenu]

Comment on attachment 391582 [details] [diff] [review]
Fixes opening of attached .eml files

r=me, but do you want to investigate Sid's suggestion?

Comment 7

[Tobias Koenig]

Hej,

using MailUtils.displayMessage(msgHdr) results in the following error

-------------------------------------------
JavaScript strict warning: chrome://messenger/content/mailWindowOverlay.js, line 1859: reference to undefined property aArgs.msgHdr.folder
JavaScript strict warning: chrome://messenger/content/mailWindowOverlay.js, line 1903: reference to undefined property aMsgHdr.folder
JavaScript error: chrome://messenger/content/mailWindowOverlay.js, line 1903: aMsgHdr.folder is undefined
WARNING: Positioned frame that does not handle positioned kids; looking further up the parent chain: file /mnt/archive/src/credativ/mozilla_head_branch/thunderbird_hg/src/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7803
WARNING: Positioned frame that does not handle positioned kids; looking further up the parent chain: file /mnt/archive/src/credativ/mozilla_head_branch/thunderbird_hg/src/mozilla/layout/base/nsCSSFrameConstructor.cpp, line 7803
-------------------------------------------
so I doubt we can use it here... until this is yet another bug that has to be fixed first ;)

Ciao,
Tobias

Comment 8

[Rain [:rain1] (inactive)]

Ah, OK. Yeah, it makes sense for the attachment to have no folder. Never mind -- you can still use MailUtils.openMessageInNewWindow if you wish :)

Comment 9

[Tobias Koenig]

Attachment: Make use of MailUtils.openMessageInNewWindow

Using MailUtils.openMessageInNewWindow(msgHdr) works as well and simplifies the code a bit.

Comment 10

[David :Bienvenu]

Comment on attachment 392495 [details] [diff] [review]
Make use of MailUtils.openMessageInNewWindow

thx for the patch.

Comment 11

[Tobias Koenig]

Who would be a candidate for super-review?

Comment 12

[Magnus Melin [:mkmelin]]

mail/ only changes don't need sr

Comment 13

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/ef7e80d80567