449323 - move SVG effect properties to nsSVGEffects

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

This is just a cleanup step to separate some stuff out of nsSVGUtils. We also need to make the properties accessible via nsSVGEffects.h so that future code in nsSVGIntegrationUtils can use them.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 332484 [details] [diff] [review]
fix

sr=mats

I assume there will be a follow-up patch to remove the "Effect helper
functions" block from nsSVGUtils.cpp and use nsSVGEffects instead?
Or you can easily include that in this bug if you want.

-    /**
-     * Override IsPersistent because we want to keep tracking the element
-     * for the ID even when it changes.
-     */
-    virtual PRBool IsPersistent() { return PR_TRUE; }

The above comment got lost in the transition.

Make sure the GetReferencedFrame() comment isn't lost.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

(In reply to comment #2)
> (From update of attachment 332484 [details] [diff] [review])
> sr=mats
> 
> I assume there will be a follow-up patch to remove the "Effect helper
> functions" block from nsSVGUtils.cpp and use nsSVGEffects instead?
> Or you can easily include that in this bug if you want.

Yeah, I meant to include that but I forgot. So I just included it and pushed (03693a68bee3). Thanks.