Closed
Bug 449435
Opened 16 years ago
Closed 16 years ago
spacer attribute mapping code should not depend on computed style data
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b1
People
(Reporter: dbaron, Assigned: dbaron)
Details
Attachments
(2 files)
|
8.02 KB,
patch
|
Details | Diff | Splinter Review | |
|
2.11 KB,
patch
|
bzbarsky
:
review+
bzbarsky
:
superreview+
|
Details | Diff | Splinter Review |
The spacer attribute mapping code currently depends on computed style data. It's not supposed to do this; it should just depend on the markup.
I've had a reasonably simple patch to fix this sitting in my tree for ages.
|
Assignee | |
Comment 1•16 years ago
|
||
|
|
Assignee | |
Comment 2•16 years ago
|
||
Attachment #332561 -
Flags: superreview?(bzbarsky)
Attachment #332561 -
Flags: review?(bzbarsky)
|
||
Comment 3•16 years ago
|
||
Comment on attachment 332561 [details] [diff] [review]
patch (diff -w)
>+ nsAutoString tmp(value->GetStringValue());
|tmp| could be a |const nsString&|, right?
Other than that, looks good.
Attachment #332561 -
Flags: superreview?(bzbarsky)
Attachment #332561 -
Flags: superreview+
Attachment #332561 -
Flags: review?(bzbarsky)
Attachment #332561 -
Flags: review+
|
|
Assignee | |
Comment 4•16 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in
before you can comment on or make changes to this bug.
Description
•