spacer attribute mapping code should not depend on computed style data

RESOLVED FIXED in mozilla1.9.1b1

Status

()

RESOLVED FIXED
11 years ago
10 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

Trunk
mozilla1.9.1b1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

The spacer attribute mapping code currently depends on computed style data.  It's not supposed to do this; it should just depend on the markup.

I've had a reasonably simple patch to fix this sitting in my tree for ages.
Comment on attachment 332561 [details] [diff] [review]
patch (diff -w)

>+      nsAutoString tmp(value->GetStringValue());

|tmp| could be a |const nsString&|, right?

Other than that, looks good.
Attachment #332561 - Flags: superreview?(bzbarsky)
Attachment #332561 - Flags: superreview+
Attachment #332561 - Flags: review?(bzbarsky)
Attachment #332561 - Flags: review+
Landed: http://hg.mozilla.org/mozilla-central/rev/00a9515116e5
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
You need to log in before you can comment on or make changes to this bug.