449447 - [FIX]Reuse the caching GetNthIndex for first/last/onlyChild selectors

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Like so

See bug 128585 comment 13.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 332574 [details] [diff] [review]
Like so

Is there a way we can make things assert if the content tree mutates
during GetNthIndex?  Maybe at least an NS_ASSERTION at the end that
GetChildArray() still returns the same thing?  (If there's some
state we can push that would trigger such assertions elsewhere, even
better.)

Please add some :first-child, :last-child, and :only-child tests to
test_selectors.html ?  And maybe some for :first-node and :last-node
too?  (No need to do tons unless you want to, but we should have
something.)

r+sr=dbaron with that

Comment 2

[Boris Zbarsky [:bzbarsky]]

> Is there a way we can make things assert if the content tree mutates
> during GetNthIndex?

I filed bug 451053 on this.

Added some tests for this stuff.

Pushed changeset a0a61f95d6aa.