449463 - outparams doesn't work on mac

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Benjamin Smedberg]

Attachment: isGCCApple fixups in gcc_compat.js

The outparams (treehydra) analysis doesn't seem to work on mac. I figured a couple fixes out myself (attached), but now I'm stuck with the following error:

/builds/gcc-dehydra/dehydra/libs/treehydra.js:12: JS Exception: No gstmt in this lazy object
:0:	#0: Error("No gstmt in this lazy object")
/builds/gcc-dehydra/dehydra/libs/treehydra.js:12:	#1: unhandledLazyProperty("gstmt")
/builds/gcc-dehydra/dehydra/libs/gcc_compat.js:89:	#2: GIMPLE_STMT_OPERAND([object GCCNode],1)
../../../src/xpcom/analysis/mayreturn.js:22:	#3: ([object GCCNode],[object Object])
/builds/gcc-dehydra/dehydra/libs/unstable/analysis.js:268:	#4: ([object GCCNode])
/builds/gcc-dehydra/dehydra/libs/unstable/analysis.js:228:	#5: ()
../../../src/xpcom/analysis/../../../src/xpcom/analysis/outparams.js:91:	#6: ()
../../../src/xpcom/analysis/../../../src/xpcom/analysis/outparams.js:88:	#7: process_tree([object GCCNode])
../../../src/xpcom/analysis/../../../src/xpcom/analysis/static-checking.js:70:	#8: process_tree([object GCCNode])
gmake[3]: *** [nsArrayUtils.o] Error 1

Also, I see isGCCApple and I'm almost certain that what we mean is "isGCC42", since that seems to be the real difference being checked.

Comment 1

[Vlad Sukhoy]

Indeed, "isGCC42" is more appropriate.

Comment 2

[(dormant account)]

(In reply to comment #1)
> Indeed, "isGCC42" is more appropriate.
> 

Didn't we have this discussion before? I thought it turned out that apple has a funny way of doing call_exprs or something else that wouldn't be happening on GCC on non-apple platforms.

Comment 3

[Vlad Sukhoy]

I think call_expr's arguments being stored on the chain (one of the more annoying things indeed) is actually gcc42. That we are using #ifdef APPLE to detect that is probably a bug. I think there are just a couple really apple-specific places in the code, I do recall though that detecting the target gcc version at compile time proved to be nontrivial. 

Comment 4

[Vlad Sukhoy]

Attachment: treehydra fixes

This patch includes: these fixups in gcc compat JS layer and more of that, use isGCC42 instead of isGCCApple, gcc42-specific fix to treehydra bootstrapping to fix location to string conversion in treehydra that is used in outparams. Also need visibility fixups for gcc 4.2 from bug 449639. Basically outparams run with these two patches and the following patch to outparams themselves. I wonder who is the best reviewer for this atm?

Comment 5

[Vlad Sukhoy]

Attachment: outparams fix

Basically use a gcc42-compatible way to retrieving the function node for a call.

Comment 6

[(dormant account)]

Comment on attachment 335272 [details] [diff] [review]
treehydra fixes

good work.

Comment 7

[Vlad Sukhoy]

Pushed treehydra fixes: b086b7e8aa3f, outparams mod: 5d2eb4202119.