449492 - "Actions" box overlaps recommendations box

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot of overlap

URL: http://support-stage.mozilla.org/en-US/kb/Dynamic+Content

The "Actions" box overlaps the "If you have any recommendations for other text blocks, please comment on this article." box.

Comment 1

[Brian Krausz]

There is no easy way to fix this (since the actions box needs to be a float), and I don't see it as a problem.  I'd like to WONTFIX...second opinion?

Comment 2

[Majken Connor [:Kensie]]

if there is text all the way across will it be hidden by the actions box or will it flow around?

Comment 3

[Brian Krausz]

It flows around, only the background continues behind the box.

Comment 4

[Paul Craciunoiu [:paulc]]

r19577 (trunk), r19576 (prod)
Added a simple "clear:both" to the recommendations box.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED when logged in to http://support-stage.mozilla.org/en-US/kb/Adding+screenshots

Comment 6

[David Tenser [:djst]]

I only really discovered this now, and it really doesn't look good. I guess what Brian said was that we can't solve this the right way (having the background flow around the text), but I would argue that adding the clear:both to push the whole notification below the total height of the Actions box is way worse, because it even pushes the main content of the article under the fold for some screen resolutions.

Why can't we just make the Actions box background opaque on the right side and adjust the z-order so you can't see the notification's background on its right side?

Comment 7

[Paul Craciunoiu [:paulc]]

David, could you do a quick screenshot of what you mean?

Comment 8

[David Tenser [:djst]]

Actually, in attachment 332611 [details] it looks like nothing of the notification background showed up on the right side, which is a good thing; I must have remembered that wrong because I was sure I saw the notification sticking out on the right side of the Actions box.

So basically there are three cases:

a) Notification completely covered by Actions box. Not an issue, based on the assumptions above.

b) Notification partly covered by Actions box. This is the case in attachment 332611 [details]. We can't really do much about that.

c) Notification not covered by Actions box. Nothing to solve here. :)

So, my request is that we revert the patch that went in here to restore the previous appearance and live with the fact that it looks half broken when the Actions box ends in the middle of the notification height. That's better than pushing the whole content down way below the fold.

Comment 9

[David Tenser [:djst]]

(In reply to comment #7)
> David, could you do a quick screenshot of what you mean?

For an example of how the new behavior is not very nice, look at https://support.mozilla.com/en-US/kb/Private+Browsing and select Firefox 3.0 in the Actions box.

Actually when I look at that screenshot, I see that the notification box is indeed outside the Action box's right edge as I remembered. Seems like an easy fix for that is to make sure the Actions box is fully right aligned (without margin-right).

Comment 10

[Chris Ilias [:cilias]]

I've filed bug 511825 to revert this, and bug 511742 to come up with a long-term solution.