Closed Bug 449511 Opened 17 years ago Closed 17 years ago

get_param_list() takes no argument

Categories

(Bugzilla :: Administration, task)

task
Not set
trivial

Tracking

()

RESOLVED FIXED
Bugzilla 3.2

People

(Reporter: LpSolit, Assigned: LpSolit)

Details

Attachments

(2 files)

Attached patch patch, v1Splinter Review
When implementing bug 304601 and bug 328637, I initially added an optional argument to get_param_list() to work around a problem in Bugzilla/Config/BugFields.pm. We finally checked in a patch for Bugzilla/Config/BugFields.pm which didn't require this argument, but the fix for editparams.cgi still contained it. This argument has never been in use, nowhere, and should go away.
Attachment #332656 - Flags: review?(mkanat)
Attachment #332656 - Flags: review?(wurblzap)
Comment on attachment 332656 [details] [diff] [review] patch, v1 r=bkor by inspection
Attachment #332656 - Flags: review?(wurblzap)
Attachment #332656 - Flags: review?(mkanat)
Attachment #332656 - Flags: review+
Flags: approval3.2+
Flags: approval3.0+
Flags: approval+
Attached patch patch for 3.2Splinter Review
get_param_list() appears twice on 3.2 and 3.0.
Attachment #334508 - Flags: review?(bugzilla-mozilla)
OK, the patch doesn't apply cleanly on 3.0. It's so minor that I don't want to bother with it on this branch. tip: Checking in editparams.cgi; /cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v <-- editparams.cgi new revision: 1.50; previous revision: 1.49 done 3.2rc1: Checking in editparams.cgi; /cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v <-- editparams.cgi new revision: 1.48.2.1; previous revision: 1.48 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Flags: approval3.0+
Resolution: --- → FIXED
Target Milestone: Bugzilla 3.0 → Bugzilla 3.2
Attachment #334508 - Flags: review?(bugzilla-mozilla)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: