get_param_list() takes no argument

RESOLVED FIXED in Bugzilla 3.2

Status

()

--
trivial
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: LpSolit, Assigned: LpSolit)

Tracking

Bugzilla 3.2
Bug Flags:
approval +
approval3.2 +

Details

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
Created attachment 332656 [details] [diff] [review]
patch, v1

When implementing bug 304601 and bug 328637, I initially added an optional argument to get_param_list() to work around a problem in Bugzilla/Config/BugFields.pm. We finally checked in a patch for Bugzilla/Config/BugFields.pm which didn't require this argument, but the fix for editparams.cgi still contained it. This argument has never been in use, nowhere, and should go away.
Attachment #332656 - Flags: review?(mkanat)
(Assignee)

Updated

10 years ago
Attachment #332656 - Flags: review?(wurblzap)

Comment 1

10 years ago
Comment on attachment 332656 [details] [diff] [review]
patch, v1

r=bkor by inspection
Attachment #332656 - Flags: review?(wurblzap)
Attachment #332656 - Flags: review?(mkanat)
Attachment #332656 - Flags: review+
(Assignee)

Updated

10 years ago
Flags: approval3.2+
Flags: approval3.0+
Flags: approval+
(Assignee)

Comment 2

10 years ago
Created attachment 334508 [details] [diff] [review]
patch for 3.2

get_param_list() appears twice on 3.2 and 3.0.
Attachment #334508 - Flags: review?(bugzilla-mozilla)
(Assignee)

Comment 3

10 years ago
OK, the patch doesn't apply cleanly on 3.0. It's so minor that I don't want to bother with it on this branch.

tip:

Checking in editparams.cgi;
/cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v  <--  editparams.cgi
new revision: 1.50; previous revision: 1.49
done

3.2rc1:

Checking in editparams.cgi;
/cvsroot/mozilla/webtools/bugzilla/editparams.cgi,v  <--  editparams.cgi
new revision: 1.48.2.1; previous revision: 1.48
done
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Flags: approval3.0+
Resolution: --- → FIXED
Target Milestone: Bugzilla 3.0 → Bugzilla 3.2
(Assignee)

Updated

10 years ago
Attachment #334508 - Flags: review?(bugzilla-mozilla)
You need to log in before you can comment on or make changes to this bug.