449564 - Remove duplicate typedef of sa_event_callback_t at liboggplay_audio

Status: RESOLVED FIXED

(Core :: Audio/Video, defect)

Description

[Bo Yang]

Attachment: proposal patch

There is a duplicate typedef in the file modules/liboggplay_audio/sydney_audio_waveapi.c and mingw gcc complain this. The first definition is located at modules/liboggplay_audio/sydney_audio.h. Just remove it.

Comment 1

[Bo Yang]

Report it to http://trac.annodex.net/ticket/415 

Comment 2

[Bo Yang]

(In reply to comment #1)
> Report it to http://trac.annodex.net/ticket/415 
> 

The above ticket is fixed and the patch is applied to browser_plugin.

Comment 3

[Benjamin Smedberg]

Chris, do you have an ETA on picking up a new liboggplay revision, so that we can get mingw builds working?

Comment 4

[cajbir (:cajbir)]

Upstream does not appear to have applied the patch. At least, I can't see the change in svn. I'll get in touch with them and see what happened.

Comment 5

[cajbir (:cajbir)]

Attachment: Original patch plus addition to README_MOZILLA

I've added a note to the README_MOZILLA that this patch was applied. Upstream will be making this change shortly but they are currently refactoring the audio part of browser_plugin into a separate library. I'll update to that new library when completed in a separate bug.

Comment 6

[Reed Loden [:reed]]

Pushed as 17095:397b37c682ed.