Closed Bug 449566 Opened 14 years ago Closed 14 years ago

cairo-qpainter-surface.cpp fails to compile with gcc 4.3.x

Categories

(Core Graveyard :: Widget: Qt, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bero, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (compatible; Konqueror/3.5; en_US) KHTML/3.5.9 (like Gecko)
Build Identifier: Last hg changeset: 16538:1f6895511812

cairo-qpainter-surface.cpp uses std::auto_ptr, but doesn't #include <memory>, causing the compiler to complain about std::auto_ptr not existing.

Reproducible: Always

Steps to Reproduce:
Install gcc 4.3.x or later, compile mozilla-qt
Actual Results:  
Build barfs

Expected Results:  
It compiles
Fix:

--- mozilla-qt/gfx/cairo/cairo/src/cairo-qpainter-surface.cpp.ark       2008-08-
07 12:03:00.029048960 +0200
+++ mozilla-qt/gfx/cairo/cairo/src/cairo-qpainter-surface.cpp   2008-08-07 12:03
:17.267054280 +0200
@@ -41,6 +41,8 @@

 #include "cairo-qpainter.h"

+#include <memory>
+
 #include <QtGui/QPainter>
 #include <QtGui/QPaintEngine>
 #include <QtGui/QPaintDevice>
After fixing this, the build bombs out a bit later:

nsWindow.h:354: error: multiple parameters named 'aEvent'
Fix for that:

--- mozilla-qt/widget/src/qt/nsWindow.h.ark     2008-08-07 12:33:38.916163623 +0200
+++ mozilla-qt/widget/src/qt/nsWindow.h 2008-08-07 12:36:18.780038219 +0200
@@ -351,7 +351,7 @@ private:
     void              *SetupPluginPort(void);
     nsresult           SetWindowIconList(const nsCStringArray &aIconList);
     void               SetDefaultIcon(void);
-    void               InitButtonEvent(nsMouseEvent &aEvent, QMouseEvent *aEvent, int aClickCount = 1);
+    void               InitButtonEvent(nsMouseEvent &event, QMouseEvent *aEvent, int aClickCount = 1);
     PRBool             DispatchCommandEvent(nsIAtom* aCommand);
     QWidget           *createQWidget(QWidget *parent, nsWidgetInitData *aInitData);
Attached patch Patch a=bero@arklinux.org (obsolete) — Splinter Review
Attachment #333016 - Flags: review?(pavlov)
Attachment #333016 - Attachment is obsolete: true
Attachment #333091 - Flags: review?(pavlov)
Attachment #333016 - Flags: review?(pavlov)
Attachment #333091 - Flags: review?(pavlov) → review+
Fixed:
http://hg.mozilla.org/index.cgi/mozilla-central/rev/9ba4c8bfa399
Status: UNCONFIRMED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.