Closed Bug 449577 Opened 11 years ago Closed 11 years ago

Remove obsolete rendering hints


(Core :: Graphics, defect)

Not set





(Reporter: smontagu, Assigned: smontagu)




(1 file)

A whole lot of the rendering hints in nsIRenderingContext.h are never used, or always true, or always false, so can be removed.
Depends on: 446675, 447693
Attached patch PatchSplinter Review
As it turns out, none of the rendering hints are used any more, so I got rid of GetHints() altogether.

If we don't care about breaking BeOS and photon, this can go in as is. Otherwise I either have to wait for them to be removed in the blocking bugs, or patch nsRenderingContextBeOS and nsRenderingContextPh as well.
Attachment #332852 - Flags: superreview?(roc)
Attachment #332852 - Flags: review?(roc)
Comment on attachment 332852 [details] [diff] [review]

Just land this.

All the FindSafeLength stuff can be removed too... separate patch.
Attachment #332852 - Flags: superreview?(roc)
Attachment #332852 - Flags: superreview+
Attachment #332852 - Flags: review?(roc)
Attachment #332852 - Flags: review+
BeOS gfx should be removed (it's using thebes whe nit's built), and photon is being removed in bug 447693.  So this should be good to go.
Pushed to mozilla-central.
Closed: 11 years ago
No longer depends on: 446675, 447693
Flags: in-testsuite-
Resolution: --- → FIXED
Depends on: 450132
(In reply to comment #2)
> All the FindSafeLength stuff can be removed too... separate patch.

Taking that to its logical conclusion would mean removing all the GetWidth, DrawString, GetTextDimensions and GetBoundingMetrics methods from nsRenderingContextImpl and removing the "Internal" from the methods in nsThebesRendingContext. Is that what you meant, or am I going too far?
You need to log in before you can comment on or make changes to this bug.