449733 - White "Other Firefox Support" highlighted link is hard to read against the background

Status: VERIFIED FIXED

(support.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Screenshot

This was mentioned over in https://bugzilla.mozilla.org/show_bug.cgi?id=442182#c26, and is a regression from that bug.

Steps to Reproduce:

1. Load http://support-stage.mozilla.org/en-US/kb/Other+Firefox+support
2. Look at the white "Other Firefox Support" link against the background

See screenshot.

Comment 1

[Chris Ilias [:cilias]]

FWIW, in order to disable commments on that article, I've switched it to mozad.css.

Comment 2

[Brian Krausz]

As per Comment #1, it'll be fine on production.  However, this doesn't seem to go well with the "How to Contribute" category that the main title has.  Regardless, it's ok for now, downgrading to normal and assigning to Laura since I imagine I'll be gone before we come up with a good solution (I'm sure djst will think of something).

Easiest thing to do is to shift the header down 15 pixels so that the blue is lower.  Not the best solution, but the easiest.

Comment 3

[Chris Ilias [:cilias]]

Attachment: when logged out

The same problem still appears when logged out. See screenshot.

Comment 4

[Chris Ilias [:cilias]]

Attachment: when logged in

Comment 5

[Laura Thomson :laura]

Not sure I understand why this is on a different template than the other pages - the gray header image also looks kind of funny on the blue.

Comment 6

[Les Orchard [:lorchard]]

Attachment: Tweaks to recolor links and move background on "mini" style variant

It looks like some pages have a "mini" style variant, where the search bar is hidden and there's no large title at the top - not sure why it's this way.  Also, I wasn't able to reproduce Chris Ilias' screenshot differences between logged in and logged out.

As a quick fix, I tweaked the CSS in this patch to give the sidebar links a blue color like other links on the page when the "mini" variant is in effect.  Additionally, I pushed the background up a bit in order to make the grey section rule look better.

Comment 7

[Laura Thomson :laura]

Comment on attachment 335535 [details] [diff] [review]
Tweaks to recolor links and move background on "mini" style variant

WFM

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Have people been changing templates?  http://support.mozilla.com/en-US/kb/Other+Firefox+support and staging are both fine, seemingly without this fix...

Comment 9

[Les Orchard [:lorchard]]

Hmm.. might need to look into that a little more - seems confusing, since that page is "Other Firefox support" but the big title says "How to Contribute", which is the next link down in the sidenav.

Comment 10

[Chris Ilias [:cilias]]

see comment 1

Comment 11

[Les Orchard [:lorchard]]

checked in my patch as r17993 on trunk, r17994 on prod.  

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

I don't know how to verify this until the change to use the mozad.css stylesheet in comment 1 is reverted.

Comment 13

[Les Orchard [:lorchard]]

Huh, I must not understand comment 1, because I'm not seeing mozad.css anywhere on the page on trunk

Comment 14

[Chris Ilias [:cilias]]

Okay, I've switched it back on prod.

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #14)
> Okay, I've switched it back on prod.

Chris, could you do this on stage, too, so that I can verify it?  Thanks!

http://support-stage.mozilla.org/en-US/kb/Other+Firefox+support

Comment 16

[Chris Ilias [:cilias]]

Looks like it's already applied to staging.

Comment 17

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED; don't know what I was thinking/seeing.  Thanks, Chris.