Fix splashos2.rc for comm-central static builds

RESOLVED FIXED

Status

--
blocker
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: mozilla, Assigned: mozilla)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Static builds from comm-central are broken, because splashos2.rc assumes that the widget dir is two directories up from mail/app and suite/app, and the pointer resources are in ..\..\widget\src\os2\res. With the standard (?) comm-central setup where mozilla-central is located in the mozilla directory below comm-central, this is now  ..\..\mozilla\widget\src\os2\res. 

I wonder if the Windows version (mail/app/splash.rc) is similarly broken, there I see the same relative paths that will probably be just as wrong for comm-central builds...

Hmm, there is no "Build Config" component in MailNews Core...
(Assignee)

Comment 1

10 years ago
Created attachment 332906 [details] [diff] [review]
fix

This should do it for OS/2.

Also asking for sr to make sure that I understood the comm-central directory setup correctly. Should I fix this in Windows' splash.rc, too?
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #332906 - Flags: superreview?(dmose)
Attachment #332906 - Flags: review?(mozilla)
Comment on attachment 332906 [details] [diff] [review]
fix

Dan probably doesn't know the build config for comm-central as well as me and Robert, so I'll still this from him.

This looks fine.

It does indeed look like the splash.rc are also broken, though I'm not sure what effect they will have. Could you file a bug please?

fwiw, there's an open bug about getting a Build Config component set up within MailNews Core.
Attachment #332906 - Flags: superreview?(dmose) → review+
(Assignee)

Comment 3

10 years ago
Comment on attachment 332906 [details] [diff] [review]
fix

Thanks, that was really fast.

Actually, I already verified for OS/2 that this works, so I don't think we need mkaply's additional review.
Attachment #332906 - Flags: review?(mozilla)
(Assignee)

Comment 4

10 years ago
My first push to comm-central, seems to have worked fine (changeset 68:60eef23d349e or http://hg.mozilla.org/comm-central/index.cgi/rev/60eef23d349e).
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.