Last Comment Bug 449812 - useless "select all" context menu entry on right click message pane when no message selected (e.g. in an empty folder)
: useless "select all" context menu entry on right click message pane when no m...
Product: Thunderbird
Classification: Client Software
Component: Message Reader UI (show other bugs)
: Trunk
: All All
-- trivial (vote)
: Thunderbird 14.0
Assigned To: Magnus Melin
Depends on:
  Show dependency treegraph
Reported: 2008-08-08 12:20 PDT by der_tuxman
Modified: 2012-05-21 02:04 PDT (History)
5 users (show)
mkmelin+mozilla: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

proposed fix (4.48 KB, patch)
2012-03-11 12:59 PDT, Magnus Melin
squibblyflabbetydoo: review-
Details | Diff | Splinter Review
proposed fix v2 (3.56 KB, patch)
2012-03-19 13:12 PDT, Magnus Melin
squibblyflabbetydoo: review+
Details | Diff | Splinter Review

Description User image der_tuxman 2008-08-08 12:20:53 PDT
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv: Gecko/2008070208 Firefox/3.0.1
Build Identifier: Version (20080708)


I just right-clicked into the message pane with no actual message selected and I got a menu with one entry, "select all" ("Alles auswählen", as I'm German)...

Now I wonder what it's for... maybe this should be changed?

Reproducible: Always

Steps to Reproduce:
1. Start TB without a message selected
2. Right-click the empty message pane
Actual Results:  
A useless menu item appears :)

Here's a screenshot:

Comment 1 User image Magnus Melin 2008-08-25 15:05:48 PDT
Confirming on linux/trunk.
Comment 2 User image :aceman 2012-01-10 11:59:25 PST
On the other hand, if even this item gets removed, the menu will be completely empty. It would look something like a 5x5px square. Would that be better?
Or should it then be completely hidden?
Comment 3 User image der_tuxman 2012-01-10 12:31:08 PST
+1 for "hidden".
Comment 4 User image Magnus Melin 2012-03-11 12:59:01 PDT
Created attachment 604786 [details] [diff] [review]
proposed fix
Comment 5 User image Jim Porter (:squib) 2012-03-18 15:18:10 PDT
Comment on attachment 604786 [details] [diff] [review]
proposed fix

Review of attachment 604786 [details] [diff] [review]:

This breaks the context menu in the start page (and possibly elsewhere), so we probably need something a bit more complicated to detect this.

On the other hand, if we ever merge Mail Summaries into Thunderbird, this won't matter, since the message pane should never be blank then.
Comment 6 User image Magnus Melin 2012-03-19 13:12:23 PDT
Created attachment 607273 [details] [diff] [review]
proposed fix v2

Yeah i always forget about the start page...
Comment 7 User image Jim Porter (:squib) 2012-04-15 14:09:14 PDT
Comment on attachment 607273 [details] [diff] [review]
proposed fix v2

Review of attachment 607273 [details] [diff] [review]:

Sorry about the delay. I've tried this out and it seems to work.
Comment 8 User image Magnus Melin 2012-04-19 10:59:15 PDT -> FIXED

Note You need to log in before you can comment on or make changes to this bug.