449812 - useless "select all" context menu entry on right click message pane when no message selected (e.g. in an empty folder)

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[der_tuxman]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: Version 2.0.0.16 (20080708)

Hi,

I just right-clicked into the message pane with no actual message selected and I got a menu with one entry, "select all" ("Alles auswählen", as I'm German)...

Now I wonder what it's for... maybe this should be changed?

Reproducible: Always

Steps to Reproduce:
1. Start TB without a message selected
2. Right-click the empty message pane
Actual Results:  
A useless menu item appears :)


Here's a screenshot:

http://img3.imagebanana.com/img/46n8ttzb/wtf.png

HTH

Comment 1

[Magnus Melin [:mkmelin]]

Confirming on linux/trunk.

Comment 2

[:aceman]

On the other hand, if even this item gets removed, the menu will be completely empty. It would look something like a 5x5px square. Would that be better?
Or should it then be completely hidden?

Comment 3

[der_tuxman]

+1 for "hidden".

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 5

[Jim Porter (:squib)]

Comment on attachment 604786 [details] [diff] [review]
proposed fix

Review of attachment 604786 [details] [diff] [review]:
-----------------------------------------------------------------

This breaks the context menu in the start page (and possibly elsewhere), so we probably need something a bit more complicated to detect this.

On the other hand, if we ever merge Mail Summaries into Thunderbird, this won't matter, since the message pane should never be blank then.

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: proposed fix v2

Yeah i always forget about the start page...

Comment 7

[Jim Porter (:squib)]

Comment on attachment 607273 [details] [diff] [review]
proposed fix v2

Review of attachment 607273 [details] [diff] [review]:
-----------------------------------------------------------------

Sorry about the delay. I've tried this out and it seems to work.

Comment 8

[Magnus Melin [:mkmelin]]

http://hg.mozilla.org/comm-central/rev/b8464bdff27c -> FIXED