449826 - detect when embedded profiles are actually sRGB

Status: REOPENED

(Core :: Graphics: Color Management, defect)

Description

[Bobby Holley (:bholley)]

A fair number of profiles on the internet have sRGB as an embedded profile. Currently, the lcms code doesn't detect this and takes the un-optimized path. We should detect this for a hopeful speedup.

Comment 1

[Bobby Holley (:bholley)]

This ended up being much slower, probably as a result of the time it took to compare the TRCs. We might still be able to optimize it down in a few cases, but it's not really worth it at this point.

Resolving as WONTFIX.

Comment 2

[Bobby Holley (:bholley)]

The perf numbers for this bug were scuttled because the patch introduced the same bug as bug 454747. Reopening for further investigation.

Comment 3

[Bobby Holley (:bholley)]

Attachment: old equality detection patch for lcms

uploading the old patch for posterity (and for jeff)

Comment 4

[Bobby Holley (:bholley)]

reassigning to jeff.

Comment 5

[Jeff Muizelaar [:jrmuizel]]

This would be especially valuable on OS X because starting with Snow Leopard the display profile is usually sRGB and we can then avoid any transformation on images that are sRGB.