449915 - flash wmode = transparent is displayed with a focus ring / frame

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[ph]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.0.1) Gecko/2008070208 Firefox/3.0.1

Whenever flash is making use of transparent background, one will experience that a grey dotted frame is drawn on click inside the flash-movie on its last pixels on every side.

As soon as removing the <param name="wmode" value="transparent"> from the object tag the flash will be integrated as expected and as it has been in FireFox2.


Reproducible: Always

Steps to Reproduce:
1. visit http://chipdisc.de/new.html or any other page having a flash movie placed with <param name="wmode" value="transparent"> in the object tag

2. click anywhere inside the flash movie
Actual Results:  
the focus ring becomes visible ( the "active element"-frame that is for example drawn when clicking a linked image ).

http://chipdisc.de/e.jpg
http://chipdisc.de/e2.jpg
http://chipdisc.de/e3.jpg

Expected Results:  
flash movies using transparency should be flawlessly integrated into webpages

solutions tried that did not fix it:

1. adding css-properties like outline: 0px; border-style: none; 
2. disabling JavaScript
3. setting browser.display.focus_ring_width = 0 in about:config
4. disabling all FireFox addons
5. visiting the page with a clean profile via ProfileManager

Comment 1

[Ria Klaassen (not reading all bugmail)]

Confirmed on Windows Vista.

Works: 2007032721
Fails: 2007032722

Regression window:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=2007-03-27+20%3A00&maxdate=2007-03-27+23%3A00

Seems to be caused by Bug 375508.

Comment 2

[Martijn Wargers (dead)]

Setting outline: 0px; on the object element, works for me. After that, the focus outline doesn't appear anymore when focusing the object (tested using current trunk build).

Comment 3

[ph]

the bug seems to be highly OS-dependand. I was using WinXP, somehow the bug doesnt appear in Linux FF. Might be that it can be fixed by adding outline: 0px; in Vista, but at least for my configuration it does not help.

Comment 4

[ph]

_on the object_: outline: 0px; solves it indeed. i was just trying to apply it to my wrapper all the time, not for the object tag itself!

Thank you for your time.

Comment 5

[Martijn Wargers (dead)]

Attachment: testcase

There is an object:focus rule in html.css that is causing the focus outline:
http://mxr.mozilla.org/mozilla-central/source/layout/style/html.css
You can only see it for windowless plugins, as the reporter said.

The focuse outline doesn't happen for embed:focus (no css rule for that in html.css).
I don't think web developers expect these kind of focus outline for plugins (Flash, etc), so it seems to me it is best to remove the object:focus selector.

Comment 6

[Martijn Wargers (dead)]

Attachment: patch

So like this. If this isn't a good idea, then I guess an embed:focus selector should be added, but I don't web developers are expecting these kind of focus outlines when Flash plugins get focused.

Comment 7

[Martijn Wargers (dead)]

Hmm, applet:focus should probably be removed then, too.

Comment 8

[Aaron Leventhal]

Comment on attachment 333225 [details] [diff] [review]
patch

r+, and please change applet:focus as well

Comment 9

[Martijn Wargers (dead)]

Attachment: patch with reftest

And also with the applet:focus selector removed as suggested.

Comment 10

[Martijn Wargers (dead)]

Attachment: failing applet test

The applet reftest was failing, probably because the plugin is being loaded at random times, which can make it look black or white.

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Should this really be changed for object:focus for all objects?

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Also, authors complain about our showing focus rings a lot, but showing the focus is good for users in at least some cases.  Why should we respond to this particular complaint by removing this particular subset of focus rings?

Comment 13

[Martijn Wargers (dead)]

Ok, perhaps this should just be left alone then.
But there is no embed:focus rule now, which is a bit strange.
Or perhaps the rule should only not apply when <object> invokes some kind of external plugin?

Comment 15

[Michelle Funches - QA]

This has been tagged for Regression and or Closure.

"the focus ring becomes visible" Not occurring in Nightly or Release - appears this has been fixed.
Version 	49.0a1
Build ID 	20160518030234
Version 	46.0.1
Build ID 	20160502172042
Considering this I will close as Resolved-WFM
Feel free to reopen if issues are still encountered, OS, FxVer, STR...