Incorrect display of background for the add review box

VERIFIED FIXED in 4.0.5

Status

addons.mozilla.org Graveyard
Public Pages
VERIFIED FIXED
10 years ago
2 years ago

People

(Reporter: Away for a while, Assigned: cesar)

Tracking

({rtl})

unspecified
4.0.5

Details

(URL)

Attachments

(3 attachments)

(Reporter)

Description

10 years ago
The add review box shows a background which is specific to LTR pages <https://addons.mozilla.org/img/rustico/left-top-corner-box.jpg> and will display out of place in RTL pages.

A corresponding <https://addons.mozilla.org/img/rustico/right-top-corner-box.jpg> background needs to be created as a horizontally flipped version of this image and be used on RTL locales.
(Assignee)

Comment 1

10 years ago
Created attachment 333459 [details]
alternative placement of corner box

Ehsan : is this the correct rendering for rtl languages?
(Reporter)

Comment 2

10 years ago
(In reply to comment #1)
> Created an attachment (id=333459) [details]
> alternative placement of corner box
> 
> Ehsan : is this the correct rendering for rtl languages?

Yes, exactly.
(Assignee)

Comment 3

10 years ago
Created attachment 333573 [details]
Corner box flipped

Corner box flipped for rtl languages
(Assignee)

Comment 4

10 years ago
Created attachment 333575 [details] [diff] [review]
proposed patch

Makes the right corner box show up for rtl languages. Just some simple css changes. You need the flipped corner image in the above attachment saved into site/app/webroot/img/rustico
Assignee: nobody → cdolivei.bugzilla
Status: NEW → ASSIGNED
Attachment #333575 - Flags: review?(laura)

Updated

10 years ago
Attachment #333575 - Flags: review?(laura) → review+
(Assignee)

Updated

10 years ago
Keywords: checkin-needed
Laura - could you check this in for Cesar, he no longer has access.

Comment 6

10 years ago
Committed in r18232.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed → push-needed
Resolution: --- → FIXED
I can't yet see this on preview, in order to verify: https://preview.addons.mozilla.org/he/firefox/reviews/add/743
(Assignee)

Comment 8

10 years ago
Laura : I think you might have forgot to check in the image as well?
Reopening; good catch, Cesar.  The SVN commit shows that just the CSS was changed.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 10

9 years ago
Added corner-box image in r20853
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago9 years ago
Resolution: --- → FIXED

Updated

9 years ago
Keywords: push-needed
(Reporter)

Comment 11

9 years ago
Thanks for checking this in!

I can see this in preview.AMO, but not on the live AMO.  Does it need the push-needed keywords again?
(In reply to comment #11)
> Thanks for checking this in!
> 
> I can see this in preview.AMO, but not on the live AMO.  Does it need the
> push-needed keywords again?

Yup; added both that and a target milestone of 4.0.5.
Keywords: push-needed
Target Milestone: --- → 4.0.5
Verified FIXED on https://preview.addons.mozilla.org/he/firefox/reviews/add/743.
Status: RESOLVED → VERIFIED
Keywords: push-needed
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.