450049 - Previews are not removed when 3 tabs are open and one is closed with Cmd+W

Status: VERIFIED INVALID

(Firefox :: Tabbed Browser, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Previews after the second tab was closed

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1a2pre) Gecko/20080810020855 Minefield/3.1a2pre ID:20080810020855

With the fix on bug 445369 it is possible to close the current selected tab within the Ctrl-Tab control. If you have a lot of tabs open, the list of previews is correctly updated - means the latest closed tab is removed. But if you only have 3 tabs open and you close a tab, its preview is not removed anymore and is replaced by the preview of the first tab.

Steps to reproduce:
1. Open the following URLs into its own tab: 
     http://www.google.de/prdhp?hl=de&tab=wf
     http://news.google.de/nwshp?hl=de&tab=wn
     http://images.google.de/imghp?hl=de&tab=wi
2. Make sure the last tab is open
3. Press Ctrl+Tab so Google News is selected
4. Press Ctrl+W to close Google News

Expected result:
The tab which contained Google News is closed and the preview is removed from the list of tabs inside the Ctrl-Tab control. Following previews should be visible: Google Products, Google Images

Actual result:
The tab which contained Google News is closed but the list of tabs is not updated. I see following previews now: Google Products, Google Images, Google Products.

I'm not able to test this on Windows because there is no nightly build available for today. Will recheck tomorrow. Aleksej, can you run a test on Linux?

Comment 1

[Dão Gottwald [:dao]]

(In reply to comment #0)
> Google Products, Google Images, Google Products.

These are the expected results. Since you can always scroll indefinitely through the list, you see repeating previews when the tab count is smaller than the number of visible previews.

The preview of the closed tab is in fact removed.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

In my opinion this isn't a satisfying behavior and will also confuse our users. When you say this is the expected result, why the ctrl-tab overlay isn't also shown when only two tabs are open? This would also add a redundant preview to the list. I believe that's the reason for. But exactly this gives us an inconsistency here.

I believe that a discussion would be really helpful before closing bugs as invalid. Reopening for now.

Comment 3

[Dão Gottwald [:dao]]

Please ask first and reopen then. :\

(In reply to comment #2)
> When you say this is the expected result, why the ctrl-tab overlay isn't also
> shown when only two tabs are open?

Because there's only one tab that you could possibly switch to.
However, if you open the panel with >2 tabs and close one of them, we don't know which tab your eventually looking for, so the panel needs to stay open.