450091 - Don't turn off shadows for transparent windows

Status: RESOLVED WONTFIX

(Core :: Widget: Cocoa, defect)

Description

[Markus Stange [:mstange]]

Attachment: fix

In bug 307204 it was decided to turn off shadows for transparent windows for the following reasons:
 1) There might be problems with updating the shadows for changing content.
 2) Invalidating shadows on every drawRect is expensive.

However, I need shadows for transparent windows for rounded context menus (bug 391984) and I'd like to have them without having to tackle bug 415443.

I haven't seen any problems with this patch in my tests on both Tiger and Leopard. And I think performance isn't that important in this case - normal windows aren't transparent, and those that are / will be (bookmarks and larry panel, context menus) aren't performance critical in any way; I also haven't felt any difference in snappiness.

Comment 1

[Markus Stange [:mstange]]

With the patch all windows / panels have shadows now (the larry and bookmarks popup didn't have them before), which I think is nice. I'm not aware of any Firefox windows that shouldn't have shadows.

Comment 2

[Håkan Waara]

So we're changing the default here. 

I'd like to know if the current users of transparent windows will be surprised/angry if we suddenly turn them on, without any ability to turn them off (basically bug 415443)...

Comment 3

[Markus Stange [:mstange]]

I'd like to know that, too - I don't know any users of transparent windows.
But they might well be... I guess it's better to just fix bug 415443.

Comment 4

[Robert O'Callahan (:roc) (email my personal email if necessary)]

So we don't want this patch?

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 333213 [details] [diff] [review]
fix

Yeah, looks like it.

Comment 6

[Håkan Waara]

(In reply to comment #3)
> I'd like to know that, too - I don't know any users of transparent windows.
> But they might well be... I guess it's better to just fix bug 415443.

Both the new security UI "Larry" and Places use transparent windows in Firefox 3. I know Songbird uses lots of transparent windows, and I suspect many other XULRunner users as well as extensions, that's why I wouldn't want to flip the default switch without the option to turn the shadows off.