450130 - KannadaStore.com search plug in for Fx3 kn post Beta release

Status: RESOLVED FIXED

(Mozilla Localizations :: kn / Kannada, defect)

Description

[Mic Berman]

following up from bug 442920 to include www.kannadastore.com as one of the default search plug-ins.
required, in this order, permission from company, confirmation of search parameters (from=fx3) and plug in plus patch

Comment 1

[Axel Hecht [:Pike]]

Adding this to the tracking for fx3.0.x (not blocking beta though)

Comment 2

[Mic Berman]

received permission from Pramod of Kannada Store today 
confirming search parameters

Comment 3

[Shankar Prasad]

Mic,
As the purpose of this is done, can you close this bug?

Shankar

Comment 4

[Axel Hecht [:Pike]]

No, we actually need an implementation for the search plugin. Stas or Gandalf can help with the actual implementation. Stas, Mic, can you quote the actual search params to use here?

Comment 5

[Mic Berman]

here's what I have from the provider
they need help understanding the parameters: from=fx3
their contact information is being sent to Stas right now for follow up

Comment 6

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: kannadastore.xml

KannadaStore file

Comment 7

[Staś Małolepszy :stas]

Comment on attachment 343079 [details]
kannadastore.xml

Gandalf, thanks a lot!

><InputEncoding>ISO-8859-1</InputEncoding>

Shouldn't we use UTF-8 whenever possible?

><Image width="16" height="16">data:image/png, (...)

I think we usually encode the icon using base 64 encoding. I think that's because it's shorter?

>    <Param name="keywords" value="{searchTerms}"/>

I'll need to check with KnnadaStore, we'll probably add <Param name="from" value="firefox"/> here as well. 

Thanks again for making this plug-in, I'll use it as a base and attach a new version once I get confirmation from KannadaStore.

Comment 8

[Axel Hecht [:Pike]]

I looked at the encoding issue, the site explicitly specifies ISO-8859-1, and the encoding ususally needs to match the site's encoding.

Shankar, can you try to search for something on Kannada on KannadaStore.com and see what happens?

Comment 9

[Shankar Prasad]

Pike,
When I tried to search by keying in some Kannada words, it gave me zero results! This is probably due the fact that nothing is listed in Kannada on that site.

Shankar

Comment 10

[Staś Małolepszy :stas]

I got a confirmation from KannadaStore.com that they want us to use <Param name="keywords" value="{searchTerms}"/> as the only parameter. This means that we can use the plug-in that Gandalf created. I also assume that we're OK with the encoding issue (although I e-mailed them about this too, waiting for a reply).

What we need now is a patch including this plug-in as well as adding a line with "kannadastore" to browser/searchplugins/list.txt. Shankar, would you like to take care of that?

Comment 11

[Staś Małolepszy :stas]

OK, Pramod from Kannada Store told me to use ISO-8859-1. They are working on Unicode support, but for now ISO-8859-1 is what they use.

Comment 12

[Shankar Prasad]

Attachment: Added kannadastore to list.txt

Comment 13

[Shankar Prasad]

Stas,
Attached the edited file and updated in mercurial as well.
Let me know is anything need to be done.

Shankar

Comment 14

[Staś Małolepszy :stas]

Attachment: Correct patch

Shankar,

First and foremost: please do not push any changes to web services (search plugins, rss readers, live bookmarks etc.) without a review. This is a sensitive part of localization and the review process is intended to help to avoid any mistakes. Also, please always submit patches (created using 'hg diff'), not whole patched files.

Apparently you forgot to 'hg add' the kannadastore.xml file. The landings should have happened on two branches: 3.1 (http://hg.mozilla.org/releases/l10n-mozilla-1.9.1/kn) and 3.2 (http://hg.mozilla.org/l10n-central/kn).

I backed out your changeset from l10n-central and applied the attached patch. I then committed it to my local l10n-central clone, and pushed twice:
1. hg push 
2. hg push mozilla-1.9.1

This is how my l10n-central clone's .hg/hgrc looks like:

[paths]
default = http://hg.mozilla.org/l10n-central/kn
default-push = ssh://hg.mozilla.org/l10n-central/kn
mozilla-1.9.1 = ssh://hg.mozilla.org/releases/l10n-mozilla-1.9.1/kn

As you can see, this way 'hg push' pushes to l10n-central and 'hg push mozilla-1.9.1' pushes to the 1.9.1 branch. I recommend you use something similar. It also works if you work the other way round, i.e. in a 1.9.1 clone. You just need to add something to the effect of "central = ssh://hg.mozilla.org/l10n-central/kn" and then do 'hg push central'. Please let me know if you have any troubles in the future, I'll be happy to help out.

Also, please remember to 'hg pull' and 'hg up' your local clones now.

Oh, and we still need to land this in CVS (for 3.0.x). Mind taking my patch and committing the change there? Thanks!

Comment 15

[Staś Małolepszy :stas]

Fixed on 1.9.0.x, too:

Checking in browser/searchplugins/list.txt;
/l10n/l10n/kn/browser/searchplugins/list.txt,v  <--  list.txt
new revision: 1.5; previous revision: 1.4
done
RCS file: /l10n/l10n/kn/browser/searchplugins/kannadastore.xml,v
done
Checking in browser/searchplugins/kannadastore.xml;
/l10n/l10n/kn/browser/searchplugins/kannadastore.xml,v  <--  kannadastore.xml
initial revision: 1.1
done