Closed Bug 450164 Opened 14 years ago Closed 14 years ago

remove leftovers from DOMi removal from installer.nsi

Categories

(Firefox :: Installer, defect)

x86
Windows Vista
defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3.1a2

People

(Reporter: steffen.wilberg, Assigned: steffen.wilberg)

References

Details

Attachments

(1 file, 1 obsolete file)

8.58 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — Splinter Review
installer.nsi still contains vestiges of DOM Inspector, which was removed by bug 339229. The options page which allows you to install DOMi is hidden because DOMi is not included in the installer package, but the code is still there.

This patch removes it. I also removed the strings, although that results in warnings when building the installer because they're still referenced by toolkit's common.nsh.
I left references to components.ini alone for that reason.
Attachment #333293 - Flags: review?(robert.bugzilla)
Comment on attachment 333293 [details] [diff] [review]
patch

(In reply to comment #0)
> Created an attachment (id=333293) [details]
> patch
> 
> installer.nsi still contains vestiges of DOM Inspector, which was removed by
> bug 339229. The options page which allows you to install DOMi is hidden because
> DOMi is not included in the installer package, but the code is still there.
> 
> This patch removes it. I also removed the strings, although that results in
> warnings when building the installer because they're still referenced by
> toolkit's common.nsh.
> I left references to components.ini alone for that reason.
A method to prevent the warning needs to be created before plussing this
Attachment #333293 - Flags: review?(robert.bugzilla) → review-
Attached patch patch v2Splinter Review
Fixed. I just had to remove the "!insertmacro createComponentsINI" line, which refers to the createComponentsINI in common.nsh.
I also removed the lines mentioning components.ini.
Attachment #333293 - Attachment is obsolete: true
Attachment #333448 - Flags: review?(robert.bugzilla)
Comment on attachment 333448 [details] [diff] [review]
patch v2

Thanks! r=me
Attachment #333448 - Flags: review?(robert.bugzilla) → review+
http://hg.mozilla.org/mozilla-central/index.cgi/rev/853b274b6f5d
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1a2
Verified landed in mozilla-central.

Robert, is there also an existing bug about removing this parts from the installer of Thunderbird?
Status: RESOLVED → VERIFIED
Doubtful but I have read they are considering leaving it as an optional install in Thunderbird and SeaMonkey.
(In reply to comment #6)
> Doubtful but I have read they are considering leaving it as an optional install
> in Thunderbird and SeaMonkey.

Mark, do you have a statement here? As I see from the installer there is no option to choose these additional components. The page is also hidden. If it should also be removed I would file a new bug. Thanks.
(In reply to comment #7)
> (In reply to comment #6)
> > Doubtful but I have read they are considering leaving it as an optional install
> > in Thunderbird and SeaMonkey.
> 
> Mark, do you have a statement here? As I see from the installer there is no
> option to choose these additional components. The page is also hidden. If it
> should also be removed I would file a new bug. Thanks.
> 
SeaMonkey is definitely retaining DOMI as an optional installation for the time being.

Thunderbird AFAIK has no option to install DOMI, and isn't intending to change that. Please file a bug for Thunderbird, cc dmose as well just to make sure.
(In reply to comment #8)
> Thunderbird AFAIK has no option to install DOMI, and isn't intending to change
> that. Please file a bug for Thunderbird, cc dmose as well just to make sure.

This is bug 450972 now.
You need to log in before you can comment on or make changes to this bug.