Closed
Bug 450177
Opened 16 years ago
Closed 16 years ago
"TestBlockingSocket.cpp(158) : warning C4390: ';' : empty controlled statement found; is this the intent?"
Categories
(Core :: Networking, defect)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla1.9.1a2
People
(Reporter: sgautherie, Assigned: sgautherie)
Details
Attachments
(1 file)
|
1.30 KB,
patch
|
Biesinger
:
review+
Biesinger
:
superreview+
|
Details | Diff | Splinter Review |
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080811184452 Minefield/3.1a2pre] (home, optim default) (W2Ksp4)
{{
.../netwerk/test/TestBlockingSocket.cpp(158) : warning C4390: ';' : empty controlled statement found; is this the intent?
}}
This is because, in a build without |PR_LOGGING| enabled, |LOG(...);| becomes |;|.Flags: in-testsuite-
|
Assignee | |
Comment 1•16 years ago
|
||
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1a2pre) Gecko/20080811184452 Minefield/3.1a2pre] (home, optim default) (W2Ksp4) If you don't like the |#ifdef|, adding brackets around |LOG()| would fix it too.
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #333306 -
Flags: superreview?(cbiesinger)
Attachment #333306 -
Flags: review?(cbiesinger)
|
||
Updated•16 years ago
|
Attachment #333306 -
Flags: superreview?(cbiesinger)
Attachment #333306 -
Flags: superreview+
Attachment #333306 -
Flags: review?(cbiesinger)
Attachment #333306 -
Flags: review+
|
|
Assignee | |
Updated•16 years ago
|
Keywords: checkin-needed
|
||
Comment 2•16 years ago
|
||
pushing to ssh://hg.mozilla.org/mozilla-central/ searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 1 changes to 1 files
|
|
Assignee | |
Updated•16 years ago
|
Attachment #333306 -
Attachment description: (Av1) <TestBlockingSocket.cpp> → (Av1) <TestBlockingSocket.cpp>
[Checkin: Comment 2]
|
||
Comment 3•16 years ago
|
||
(In reply to comment #2) > pushing to ssh://hg.mozilla.org/mozilla-central/ > searching for changes > remote: adding changesets > remote: adding manifests > remote: adding file changes > remote: added 1 changesets with 1 changes to 1 files and the changeset is ef8c0696afe5
You need to log in
before you can comment on or make changes to this bug.
Description
•