450206 - Port FeedWriter favicon code to use new favicon data URL api

Status: RESOLVED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Manish Singh]

Attachment: Port FeedWriter favicon code to use new favicon data URL api [Checkin: Comment 3]

This changes the FeedWriter code to use the new favicon data URL convenience api I added for bug #429832. I also changed the variable names to be consistent with the thinking that stuff called fooURI should actually be nsIURIs.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 333354 [details] [diff] [review]
Port FeedWriter favicon code to use new favicon data URL api
[Checkin: Comment 3]

Can you think of any good ways of testing this functionality?

Comment 2

[Manish Singh]

Hm, not really. The icons are fetched from the third party sites, who may change them at will.

I suppose one could create a entirely fake feed subscription service to test out the whole feature workflow, but I don't see a straightforward way to test this in isolation.

Comment 3

[Serge Gautherie (:sgautherie)]

Comment on attachment 333354 [details] [diff] [review]
Port FeedWriter favicon code to use new favicon data URL api
[Checkin: Comment 3]

http://hg.mozilla.org/mozilla-central/rev/72f100a276c8