Boolean chart contains the phrase "contains regexp" when it should say "matches regexp"

VERIFIED FIXED in Bugzilla 3.4

Status

()

Bugzilla
Query/Bug List
P4
trivial
VERIFIED FIXED
10 years ago
10 years ago

People

(Reporter: Guy Pyrzak, Assigned: Max Kanat-Alexander)

Tracking

3.1.4
Bugzilla 3.4

Details

(Whiteboard: [fixed by blocker])

Attachments

(1 attachment)

948 bytes, patch
Guy Pyrzak
: review+
Max Kanat-Alexander
: review-
Details | Diff | Splinter Review
(Reporter)

Description

10 years ago
The boolean charts contain the option "contains regexp" which isn't what it actually means. It should be changed to "matches regexp", which is what the search actually does.
(Reporter)

Updated

10 years ago
Whiteboard: [Good Intro Bug]
(Assignee)

Comment 1

10 years ago
Yes...didn't somebody already file this? Or did we maybe just talk about it?

Comment 2

10 years ago
Created attachment 334093 [details] [diff] [review]
Patch for Bug 450267 V1
Attachment #334093 - Flags: review?(guy.pyrzak)
(Reporter)

Comment 3

10 years ago
Comment on attachment 334093 [details] [diff] [review]
Patch for Bug 450267 V1

Looks good. I think I might want it to say "matches the regexp" but that can be done on checkin. Handing it off to max.
Attachment #334093 - Flags: review?(mkanat)
Attachment #334093 - Flags: review?(guy.pyrzak)
Attachment #334093 - Flags: review+
(Reporter)

Updated

10 years ago
Target Milestone: --- → Bugzilla 3.4
Version: unspecified → 3.1.4
(Reporter)

Updated

10 years ago
Priority: -- → P4
(Assignee)

Updated

10 years ago
Attachment #334093 - Flags: review?(mkanat) → review+
(Assignee)

Updated

10 years ago
Assignee: query-and-buglist → rupert
Flags: approval+

Comment 4

10 years ago
Comment on attachment 334093 [details] [diff] [review]
Patch for Bug 450267 V1

>-  { name => "regexp", description => "contains regexp" },
>+  { name => "regexp", description => "matches regexp" },
>   { name => "notregexp", description => "does not contain regexp" },

I disagree with this patch. If we fix "contains regexp", then we should also fix "does not contain regexp". Either change both or none.
(Assignee)

Comment 5

10 years ago
I agree with LpSolit.
Status: NEW → ASSIGNED
Flags: approval+
(Assignee)

Updated

10 years ago
Attachment #334093 - Flags: review+ → review-

Comment 6

10 years ago
This seems to be fixed in the latest code, and I think it is taking the strings from template/en/default/global/field-descs.none.tmpl
(Assignee)

Comment 7

10 years ago
Ah yes, I believe I fixed this for 3.4 as part of another patch.
Assignee: rupert → mkanat
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 8

10 years ago
Fixed by bug 463002.
Status: RESOLVED → VERIFIED
Depends on: 463002
Whiteboard: [Good Intro Bug] → [fixed by blocker]
You need to log in before you can comment on or make changes to this bug.